Page MenuHomePhabricator

[native] Create a ChangeRolesHeaderLeftButton to cancel role changes
ClosedPublic

Authored by rohan on Jun 9 2023, 11:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 12:57 PM
Unknown Object (File)
Sat, Nov 9, 11:34 AM
Unknown Object (File)
Sat, Nov 9, 11:32 AM
Unknown Object (File)
Sat, Nov 9, 8:38 AM
Unknown Object (File)
Thu, Nov 7, 7:32 PM
Unknown Object (File)
Tue, Nov 5, 9:15 AM
Unknown Object (File)
Tue, Nov 5, 9:15 AM
Unknown Object (File)
Mon, Nov 4, 10:54 AM
Subscribers

Details

Summary

Per the designs, we want the button on the top left of the screen to be 'Cancel'. This diff introduces the headerLeft component.

I followed some of the work for the invite links modal on native to get the types correct for creating a separate component for headerLeft and headerRight (later in the stack), so also adding @tomek as a non-blocking reviewer for these 3 diffs

Depends on D8157

Test Plan

Confirm that the 'Cancel' button appears on the top left of the header and closes the screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan edited the test plan for this revision. (Show Details)
rohan added a reviewer: tomek.
rohan requested review of this revision.Jun 9 2023, 11:51 AM
atul added inline comments.
native/roles/change-roles-header-left-button.react.js
11 ↗(On Diff #27587)

Could we just call this LeftHeaderCancelButton or something along those lines to make it more "general purpose" since there isn't anything "ChangeRoles" specific about this component?

This revision is now accepted and ready to land.Jun 12 2023, 1:10 PM
native/roles/change-roles-header-left-button.react.js
11 ↗(On Diff #27587)

I'd opt to leave it as is since the change roles logic gets added right after this in D8159 if that makes sense

This revision was landed with ongoing or failed builds.Jun 21 2023, 8:42 AM
This revision was automatically updated to reflect the committed changes.