Page MenuHomePhabricator
Differential D8507

[keyserver][lib] Simplify createThread return type following deprecation of old codeVersions
ClosedPublic
Actions

Authored by ashoat on Jul 15 2023, 8:04 PM.
Tags
None
Referenced Files
F6245233: D8507.diff
Fri, Apr 25, 2:00 AM
Unknown Object (File)
Tue, Apr 22, 8:25 AM
Unknown Object (File)
Sun, Apr 20, 12:49 PM
Unknown Object (File)
Sun, Apr 20, 12:25 AM
Unknown Object (File)
Sat, Apr 19, 9:32 AM
Unknown Object (File)
Wed, Apr 2, 4:22 AM
Unknown Object (File)
Mar 20 2025, 3:14 AM
Unknown Object (File)
Mar 17 2025, 10:43 PM
View All 100 Files
Subscribers
tomek

Details

Reviewers
michal
kamil
Commits
rCOMMbfb41af325bb: [keyserver][lib] Simplify createThread return type following deprecation of old…
Summary

See the first diff in the stack. We're no longer expecting to see these old codeVersions, so we're simplifying this code.

Depends on D8506

Test Plan

I tested this whole stack together by playing around with the web app and making sure thread mutation endpoints seemed to work correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
25 lines
22 lines
responders/
3 lines
lib/
types/
3 lines

Diff 28702

View Options

keyserver/src/creators/account-creator.js

Show All 10 Lines
} from '../../types/message-types.js'; } from '../../types/message-types.js';
import { import {
type CreateEntryMessageData, type CreateEntryMessageData,
type CreateEntryMessageInfo, type CreateEntryMessageInfo,
type RawCreateEntryMessageInfo, type RawCreateEntryMessageInfo,
rawCreateEntryMessageInfoValidator, rawCreateEntryMessageInfoValidator,
} from '../../types/messages/create-entry.js'; } from '../../types/messages/create-entry.js';
import type { NotifTexts } from '../../types/notif-types.js'; import type { NotifTexts } from '../../types/notif-types.js';
import type { LegacyThreadInfo } from '../../types/thread-types.js'; import type { ThreadInfo } from '../../types/thread-types.js';
import type { RelativeUserInfo } from '../../types/user-types.js'; import type { RelativeUserInfo } from '../../types/user-types.js';
import { prettyDate } from '../../utils/date-utils.js'; import { prettyDate } from '../../utils/date-utils.js';
import { ET, type EntityText } from '../../utils/entity-text.js'; import { ET, type EntityText } from '../../utils/entity-text.js';
import { notifTextsForEntryCreationOrEdit } from '../notif-utils.js'; import { notifTextsForEntryCreationOrEdit } from '../notif-utils.js';
type CreateEntryMessageSpec = MessageSpec< type CreateEntryMessageSpec = MessageSpec<
CreateEntryMessageData, CreateEntryMessageData,
RawCreateEntryMessageInfo, RawCreateEntryMessageInfo,
▲ Show 20 Lines • Show All 86 Lines • ▼ Show 20 Lines robotext(messageInfo: CreateEntryMessageInfo): EntityText {
const date = prettyDate(messageInfo.date); const date = prettyDate(messageInfo.date);
const creator = ET.user({ userInfo: messageInfo.creator }); const creator = ET.user({ userInfo: messageInfo.creator });
const { text } = messageInfo; const { text } = messageInfo;
return ET`${creator} created an event scheduled for ${date}: "${text}"`; return ET`${creator} created an event scheduled for ${date}: "${text}"`;
}, },
async notificationTexts( async notificationTexts(
messageInfos: $ReadOnlyArray<MessageInfo>, messageInfos: $ReadOnlyArray<MessageInfo>,
threadInfo: LegacyThreadInfo, threadInfo: ThreadInfo,
): Promise<NotifTexts> { ): Promise<NotifTexts> {
return notifTextsForEntryCreationOrEdit(messageInfos, threadInfo); return notifTextsForEntryCreationOrEdit(messageInfos, threadInfo);
}, },
notificationCollapseKey(rawMessageInfo: RawCreateEntryMessageInfo): string { notificationCollapseKey(rawMessageInfo: RawCreateEntryMessageInfo): string {
return joinResult(rawMessageInfo.creatorID, rawMessageInfo.entryID); return joinResult(rawMessageInfo.creatorID, rawMessageInfo.entryID);
}, },
generatesNotifs: async () => pushTypes.NOTIF, generatesNotifs: async () => pushTypes.NOTIF,
canBeSidebarSource: true, canBeSidebarSource: true,
canBePinned: false, canBePinned: false,
validator: rawCreateEntryMessageInfoValidator, validator: rawCreateEntryMessageInfoValidator,
}); });
View Options

keyserver/src/creators/thread-creator.js

Show All 10 Lines
} from '../../types/message-types.js'; } from '../../types/message-types.js';
import { import {
type CreateEntryMessageData, type CreateEntryMessageData,
type CreateEntryMessageInfo, type CreateEntryMessageInfo,
type RawCreateEntryMessageInfo, type RawCreateEntryMessageInfo,
rawCreateEntryMessageInfoValidator, rawCreateEntryMessageInfoValidator,
} from '../../types/messages/create-entry.js'; } from '../../types/messages/create-entry.js';
import type { NotifTexts } from '../../types/notif-types.js'; import type { NotifTexts } from '../../types/notif-types.js';
import type { LegacyThreadInfo } from '../../types/thread-types.js'; import type { ThreadInfo } from '../../types/thread-types.js';
import type { RelativeUserInfo } from '../../types/user-types.js'; import type { RelativeUserInfo } from '../../types/user-types.js';
import { prettyDate } from '../../utils/date-utils.js'; import { prettyDate } from '../../utils/date-utils.js';
import { ET, type EntityText } from '../../utils/entity-text.js'; import { ET, type EntityText } from '../../utils/entity-text.js';
import { notifTextsForEntryCreationOrEdit } from '../notif-utils.js'; import { notifTextsForEntryCreationOrEdit } from '../notif-utils.js';
type CreateEntryMessageSpec = MessageSpec< type CreateEntryMessageSpec = MessageSpec<
CreateEntryMessageData, CreateEntryMessageData,
RawCreateEntryMessageInfo, RawCreateEntryMessageInfo,
▲ Show 20 Lines • Show All 86 Lines • ▼ Show 20 Lines robotext(messageInfo: CreateEntryMessageInfo): EntityText {
const date = prettyDate(messageInfo.date); const date = prettyDate(messageInfo.date);
const creator = ET.user({ userInfo: messageInfo.creator }); const creator = ET.user({ userInfo: messageInfo.creator });
const { text } = messageInfo; const { text } = messageInfo;
return ET`${creator} created an event scheduled for ${date}: "${text}"`; return ET`${creator} created an event scheduled for ${date}: "${text}"`;
}, },
async notificationTexts( async notificationTexts(
messageInfos: $ReadOnlyArray<MessageInfo>, messageInfos: $ReadOnlyArray<MessageInfo>,
threadInfo: LegacyThreadInfo, threadInfo: ThreadInfo,
): Promise<NotifTexts> { ): Promise<NotifTexts> {
return notifTextsForEntryCreationOrEdit(messageInfos, threadInfo); return notifTextsForEntryCreationOrEdit(messageInfos, threadInfo);
}, },
notificationCollapseKey(rawMessageInfo: RawCreateEntryMessageInfo): string { notificationCollapseKey(rawMessageInfo: RawCreateEntryMessageInfo): string {
return joinResult(rawMessageInfo.creatorID, rawMessageInfo.entryID); return joinResult(rawMessageInfo.creatorID, rawMessageInfo.entryID);
}, },
generatesNotifs: async () => pushTypes.NOTIF, generatesNotifs: async () => pushTypes.NOTIF,
canBeSidebarSource: true, canBeSidebarSource: true,
canBePinned: false, canBePinned: false,
validator: rawCreateEntryMessageInfoValidator, validator: rawCreateEntryMessageInfoValidator,
}); });
View Options

keyserver/src/responders/thread-responders.js

Show All 10 Lines
} from '../../types/message-types.js'; } from '../../types/message-types.js';
import { import {
type CreateEntryMessageData, type CreateEntryMessageData,
type CreateEntryMessageInfo, type CreateEntryMessageInfo,
type RawCreateEntryMessageInfo, type RawCreateEntryMessageInfo,
rawCreateEntryMessageInfoValidator, rawCreateEntryMessageInfoValidator,
} from '../../types/messages/create-entry.js'; } from '../../types/messages/create-entry.js';
import type { NotifTexts } from '../../types/notif-types.js'; import type { NotifTexts } from '../../types/notif-types.js';
import type { LegacyThreadInfo } from '../../types/thread-types.js'; import type { ThreadInfo } from '../../types/thread-types.js';
import type { RelativeUserInfo } from '../../types/user-types.js'; import type { RelativeUserInfo } from '../../types/user-types.js';
import { prettyDate } from '../../utils/date-utils.js'; import { prettyDate } from '../../utils/date-utils.js';
import { ET, type EntityText } from '../../utils/entity-text.js'; import { ET, type EntityText } from '../../utils/entity-text.js';
import { notifTextsForEntryCreationOrEdit } from '../notif-utils.js'; import { notifTextsForEntryCreationOrEdit } from '../notif-utils.js';
type CreateEntryMessageSpec = MessageSpec< type CreateEntryMessageSpec = MessageSpec<
CreateEntryMessageData, CreateEntryMessageData,
RawCreateEntryMessageInfo, RawCreateEntryMessageInfo,
▲ Show 20 Lines • Show All 86 Lines • ▼ Show 20 Lines robotext(messageInfo: CreateEntryMessageInfo): EntityText {
const date = prettyDate(messageInfo.date); const date = prettyDate(messageInfo.date);
const creator = ET.user({ userInfo: messageInfo.creator }); const creator = ET.user({ userInfo: messageInfo.creator });
const { text } = messageInfo; const { text } = messageInfo;
return ET`${creator} created an event scheduled for ${date}: "${text}"`; return ET`${creator} created an event scheduled for ${date}: "${text}"`;
}, },
async notificationTexts( async notificationTexts(
messageInfos: $ReadOnlyArray<MessageInfo>, messageInfos: $ReadOnlyArray<MessageInfo>,
threadInfo: LegacyThreadInfo, threadInfo: ThreadInfo,
): Promise<NotifTexts> { ): Promise<NotifTexts> {
return notifTextsForEntryCreationOrEdit(messageInfos, threadInfo); return notifTextsForEntryCreationOrEdit(messageInfos, threadInfo);
}, },
notificationCollapseKey(rawMessageInfo: RawCreateEntryMessageInfo): string { notificationCollapseKey(rawMessageInfo: RawCreateEntryMessageInfo): string {
return joinResult(rawMessageInfo.creatorID, rawMessageInfo.entryID); return joinResult(rawMessageInfo.creatorID, rawMessageInfo.entryID);
}, },
generatesNotifs: async () => pushTypes.NOTIF, generatesNotifs: async () => pushTypes.NOTIF,
canBeSidebarSource: true, canBeSidebarSource: true,
canBePinned: false, canBePinned: false,
validator: rawCreateEntryMessageInfoValidator, validator: rawCreateEntryMessageInfoValidator,
}); });
View Options

lib/types/thread-types.js

Show All 10 Lines
} from '../../types/message-types.js'; } from '../../types/message-types.js';
import { import {
type CreateEntryMessageData, type CreateEntryMessageData,
type CreateEntryMessageInfo, type CreateEntryMessageInfo,
type RawCreateEntryMessageInfo, type RawCreateEntryMessageInfo,
rawCreateEntryMessageInfoValidator, rawCreateEntryMessageInfoValidator,
} from '../../types/messages/create-entry.js'; } from '../../types/messages/create-entry.js';
import type { NotifTexts } from '../../types/notif-types.js'; import type { NotifTexts } from '../../types/notif-types.js';
import type { LegacyThreadInfo } from '../../types/thread-types.js'; import type { ThreadInfo } from '../../types/thread-types.js';
import type { RelativeUserInfo } from '../../types/user-types.js'; import type { RelativeUserInfo } from '../../types/user-types.js';
import { prettyDate } from '../../utils/date-utils.js'; import { prettyDate } from '../../utils/date-utils.js';
import { ET, type EntityText } from '../../utils/entity-text.js'; import { ET, type EntityText } from '../../utils/entity-text.js';
import { notifTextsForEntryCreationOrEdit } from '../notif-utils.js'; import { notifTextsForEntryCreationOrEdit } from '../notif-utils.js';
type CreateEntryMessageSpec = MessageSpec< type CreateEntryMessageSpec = MessageSpec<
CreateEntryMessageData, CreateEntryMessageData,
RawCreateEntryMessageInfo, RawCreateEntryMessageInfo,
▲ Show 20 Lines • Show All 86 Lines • ▼ Show 20 Lines robotext(messageInfo: CreateEntryMessageInfo): EntityText {
const date = prettyDate(messageInfo.date); const date = prettyDate(messageInfo.date);
const creator = ET.user({ userInfo: messageInfo.creator }); const creator = ET.user({ userInfo: messageInfo.creator });
const { text } = messageInfo; const { text } = messageInfo;
return ET`${creator} created an event scheduled for ${date}: "${text}"`; return ET`${creator} created an event scheduled for ${date}: "${text}"`;
}, },
async notificationTexts( async notificationTexts(
messageInfos: $ReadOnlyArray<MessageInfo>, messageInfos: $ReadOnlyArray<MessageInfo>,
threadInfo: LegacyThreadInfo, threadInfo: ThreadInfo,
): Promise<NotifTexts> { ): Promise<NotifTexts> {
return notifTextsForEntryCreationOrEdit(messageInfos, threadInfo); return notifTextsForEntryCreationOrEdit(messageInfos, threadInfo);
}, },
notificationCollapseKey(rawMessageInfo: RawCreateEntryMessageInfo): string { notificationCollapseKey(rawMessageInfo: RawCreateEntryMessageInfo): string {
return joinResult(rawMessageInfo.creatorID, rawMessageInfo.entryID); return joinResult(rawMessageInfo.creatorID, rawMessageInfo.entryID);
}, },
generatesNotifs: async () => pushTypes.NOTIF, generatesNotifs: async () => pushTypes.NOTIF,
canBeSidebarSource: true, canBeSidebarSource: true,
canBePinned: false, canBePinned: false,
validator: rawCreateEntryMessageInfoValidator, validator: rawCreateEntryMessageInfoValidator,
}); });