Page MenuHomePhabricator
Differential D8531

[native, lib] Move resetUserStateActionType to lib
ClosedPublic
Actions

Authored by inka on Jul 18 2023, 11:40 AM.
Tags
None
Referenced Files
F3529648: D8531.id28822.diff
Tue, Dec 24, 8:37 PM
F3528170: D8531.diff
Tue, Dec 24, 8:29 AM
Unknown Object (File)
Thu, Dec 19, 2:15 AM
Unknown Object (File)
Thu, Dec 12, 1:40 AM
Unknown Object (File)
Mon, Nov 25, 1:56 AM
Unknown Object (File)
Nov 23 2024, 12:51 PM
Unknown Object (File)
Nov 10 2024, 10:54 PM
Unknown Object (File)
Nov 10 2024, 10:53 PM
View All 87 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMM8ea434915603: [native, lib] Move resetUserStateActionType to lib
Summary

As mentioned in https://linear.app/comm/issue/ENG-4377/refactor-cookie-field-in-web-redux I need to move resetUserStateActionType to lib, because the cookie filed will be in the KesyerveStore, that will be in BaseAppState, so it makes
sense it be reduced by a reducer from lib. And resetUserStateActionType influences the cookie field in redux-setup.js. Since the action will now be in lib, we can move the logic that reduces CurrentUserInfo when this action is called
to lib as well

Test Plan

ran yarn flow all. Checked that resetUserStateActionType is not reduced anywhere else.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jul 18 2023, 11:40 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 18 2023, 11:40 AM
inka added inline comments.Jul 18 2023, 11:44 AM
native/redux/redux-setup.js
331–340

This had to be moved here, because now we don't want to return from this if, we need to assign state and let it continue to baseReducer. And if we do that in the if else above, then flow is not sure about the action type and shows errors

Harbormaster completed remote builds in B20992: Diff 28782.Jul 18 2023, 11:58 AM
inka requested review of this revision.Jul 18 2023, 11:58 AM
inka added a child revision: D8532: [lib, native,keyserver] Add KeyserverStore.Jul 18 2023, 12:31 PM
michal accepted this revision.Jul 19 2023, 3:09 AM
michal added inline comments.
lib/actions/user-actions.js
323

Nit: I think we prefer exporting at the end of the file instead of inline

lib/types/redux-types.js
1171

Any reason for adding void payload here?

This revision is now accepted and ready to land.Jul 19 2023, 3:09 AM
inka updated this revision to Diff 28822.Jul 19 2023, 4:50 AM

Address review

lib/types/redux-types.js
1171

It is required by flow

Harbormaster completed remote builds in B21026: Diff 28822.Jul 19 2023, 5:09 AM
inka added a child revision: D8569: [keyserver, lib, native] Change keyserverPrefixID to ashoatKeyserverID.Jul 19 2023, 9:29 AM
inka removed a child revision: D8532: [lib, native,keyserver] Add KeyserverStore.
Closed by commit rCOMM8ea434915603: [native, lib] Move resetUserStateActionType to lib (authored by inka). · Explain WhyJul 21 2023, 1:55 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM8ea434915603: [native, lib] Move resetUserStateActionType to lib.

Revision Contents
Changeset List

PathSize
lib/
actions/
2 lines
reducers/
3 lines
types/
3 lines
native/
account/
2 lines
redux/
2 lines
26 lines

Diff 28782

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/reducers/user-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/account/logged-out-modal.react.js

Loading...
View Options

native/redux/action-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...