Page MenuHomePhabricator

[lib] introduce generic StoreOperation type
ClosedPublic

Authored by kamil on Jul 25 2023, 4:59 AM.
Tags
None
Referenced Files
F3178019: D8618.diff
Fri, Nov 8, 12:42 AM
F3176343: D8618.diff
Thu, Nov 7, 9:15 PM
F3176004: D8618.id29014.diff
Thu, Nov 7, 8:22 PM
Unknown Object (File)
Sun, Nov 3, 12:57 AM
Unknown Object (File)
Sun, Nov 3, 12:57 AM
Unknown Object (File)
Sun, Nov 3, 12:56 AM
Unknown Object (File)
Sun, Nov 3, 12:31 AM
Unknown Object (File)
Sat, Nov 2, 8:22 PM
Subscribers

Details

Summary

This is some kind of spec for data store. The purpose is to:

  1. Cleanup by fitting up existing logic into this interface
  2. Make a "contract" for needed utils for future Data Stores
  3. I think it's better to use a method from descriptive object rather than calling random util functions

The only problem will be draftStore, which does nto not have those methods (the only thing I can do rn is to create a follow-up task to improve draft operations).

Examples of usage in following diffs.

Depends on D8617

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.

Adding @atul here as blocking to get an approval of the general concept

kamil published this revision for review.Jul 25 2023, 6:35 AM

Cleanup by fitting up existing logic into this interface
Make a "contract" for needed utils for future Data Stores
I think it's better to use a method from descriptive object rather than calling random util functions

I think the approach you're taking makes a ton of sense, excited to see it all implemented.

This revision is now accepted and ready to land.Jul 25 2023, 11:49 PM
This revision was automatically updated to reflect the committed changes.