Enables setting of emoji avatars on web. As of this diff all varieties of thread avatar can be set from web. We just need to make a few layout tweaks in ThreadSettingsModalGeneralTab in order to get this ready to ship.
Depends on D8855
Details
Details
Works as expected:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D8856 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Not looking too closely
| web/avatars/thread-emoji-avatar-selection-modal.react.js | ||
|---|---|---|
| 38–40 ↗ | (On Diff #30046) | Do you really need async / await here? Can you just forward the promise? If not, can you update the Flow type for the props of EmojiAvatarSelectionModal so that it's flexible (eg. Promise<mixed>), and then forward the promise? |
Comment Actions
address feedback
| web/avatars/thread-emoji-avatar-selection-modal.react.js | ||
|---|---|---|
| 38–40 ↗ | (On Diff #30046) | Ah yeah we totally don't need async/await. Updated to address feedback. |
