Page MenuHomePhabricator

[blob-service] Minor AWS cleanups
ClosedPublic

Authored by bartek on Aug 26 2023, 12:23 AM.
Tags
None
Referenced Files
F4092006: D8961.id30349.diff
Sun, Feb 16, 5:00 PM
Unknown Object (File)
Fri, Feb 14, 9:46 PM
Unknown Object (File)
Jan 11 2025, 7:13 PM
Unknown Object (File)
Dec 14 2024, 7:42 PM
Unknown Object (File)
Dec 14 2024, 7:42 PM
Unknown Object (File)
Dec 14 2024, 7:42 PM
Unknown Object (File)
Dec 14 2024, 7:41 PM
Unknown Object (File)
Dec 14 2024, 7:30 PM
Subscribers

Details

Summary

By the way of D8959, performed some minor cleanups in blob codebase.

  1. Recently noticed that aws_sdk_{dynamodb,s3}::Client already have Arc inside, so we don't need to wrap it with Arc again.
  1. Also deleted unnecessary aws_types dependency. The type we're using is already included in aws_client. > It probably wasn't in the past and that's why it was added, but now it's not needed anymore.

Plus some very minor fixes to fix Clippy warns.

Depends on D8959

Test Plan

Blob service compiles and runs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage