Page MenuHomePhabricator
Differential D9078

[keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level
ClosedPublic
Actions

Authored by inka on Sep 5 2023, 3:02 AM.
Tags
None
Referenced Files
F3366269: D9078.diff
Mon, Nov 25, 10:31 AM
Unknown Object (File)
Sat, Nov 9, 6:52 AM
Unknown Object (File)
Wed, Nov 6, 7:08 AM
Unknown Object (File)
Mon, Nov 4, 6:08 PM
Unknown Object (File)
Oct 17 2024, 12:08 PM
Unknown Object (File)
Oct 17 2024, 12:08 PM
Unknown Object (File)
Oct 17 2024, 12:08 PM
Unknown Object (File)
Oct 17 2024, 12:07 PM
View All 74 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMMee0c28bf7e17: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux…
Summary

issue: https://linear.app/comm/issue/ENG-4462/refactor-lastcommunicatedplatformdetails-field
The last step is to remove lastCommunicatedPlatformDetails from top level of redux store

Test Plan

ran yarn flow-all. Checked that both migrations work.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Sep 5 2023, 3:02 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 3:02 AM
inka edited the summary of this revision. (Show Details)Sep 5 2023, 3:05 AM
inka edited the test plan for this revision. (Show Details)
inka added a parent revision: D9079: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from keyserverStore.Sep 5 2023, 3:13 AM
Harbormaster completed remote builds in B22379: Diff 30746.Sep 5 2023, 3:19 AM
inka requested review of this revision.Sep 5 2023, 3:19 AM
inka planned changes to this revision.Sep 5 2023, 3:39 AM

Need to add migrations

inka updated this revision to Diff 30748.Sep 5 2023, 3:49 AM
inka edited the test plan for this revision. (Show Details)

Add migrations

inka edited the test plan for this revision. (Show Details)Sep 5 2023, 3:49 AM
Harbormaster completed remote builds in B22381: Diff 30748.Sep 5 2023, 4:06 AM
michal accepted this revision.Sep 5 2023, 5:56 AM

LGTM, could you check that it still works with something like this:

  1. Disable the websocket
  2. Bump the webAndKeyserverCodeVersion version
  3. Send a message or do something else that will call an endpoint
  4. Check that redux has updated
This revision is now accepted and ready to land.Sep 5 2023, 5:56 AM
inka added a comment.Sep 5 2023, 7:11 AM
In D9078#267511, @michal wrote:

LGTM, could you check that it still works with something like this:

  1. Disable the websocket
  2. Bump the webAndKeyserverCodeVersion version
  3. Send a message or do something else that will call an endpoint
  4. Check that redux has updated

I removed Socket from root, bumped the version and redux got updated

Closed by commit rCOMMee0c28bf7e17: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux… (authored by inka). · Explain WhySep 5 2023, 7:20 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMee0c28bf7e17: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux….

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
5 lines
lib/
reducers/
5 lines
types/
1 line
native/
redux/
19 lines
1 line
2 lines
web/
redux/
21 lines
2 lines

Diff 30774

View Options

keyserver/src/responders/website-responders.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

native/redux/state-types.js

Loading...
View Options

web/redux/persist.js

Loading...
View Options

web/redux/redux-setup.js

Loading...