Page MenuHomePhabricator

[keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level
ClosedPublic

Authored by inka on Sep 5 2023, 3:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 7:08 AM
Unknown Object (File)
Mon, Nov 4, 6:08 PM
Unknown Object (File)
Thu, Oct 17, 12:08 PM
Unknown Object (File)
Thu, Oct 17, 12:08 PM
Unknown Object (File)
Thu, Oct 17, 12:08 PM
Unknown Object (File)
Thu, Oct 17, 12:07 PM
Unknown Object (File)
Thu, Oct 17, 12:05 PM
Unknown Object (File)
Oct 4 2024, 6:29 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-4462/refactor-lastcommunicatedplatformdetails-field
The last step is to remove lastCommunicatedPlatformDetails from top level of redux store

Test Plan

ran yarn flow-all. Checked that both migrations work.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka edited the test plan for this revision. (Show Details)
inka requested review of this revision.Sep 5 2023, 3:19 AM
inka planned changes to this revision.Sep 5 2023, 3:39 AM

Need to add migrations

inka edited the test plan for this revision. (Show Details)

Add migrations

LGTM, could you check that it still works with something like this:

  1. Disable the websocket
  2. Bump the webAndKeyserverCodeVersion version
  3. Send a message or do something else that will call an endpoint
  4. Check that redux has updated
This revision is now accepted and ready to land.Sep 5 2023, 5:56 AM

LGTM, could you check that it still works with something like this:

  1. Disable the websocket
  2. Bump the webAndKeyserverCodeVersion version
  3. Send a message or do something else that will call an endpoint
  4. Check that redux has updated

I removed Socket from root, bumped the version and redux got updated