Page MenuHomePhabricator
Differential D9138

[feature-flags] Standardize localstack and http config
ClosedPublic
Actions

Authored by bartek on Sep 12 2023, 12:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 7:10 PM
Unknown Object (File)
Fri, Nov 22, 2:50 PM
Unknown Object (File)
Wed, Nov 13, 7:41 PM
Unknown Object (File)
Wed, Nov 13, 7:06 PM
Unknown Object (File)
Tue, Nov 12, 11:51 AM
Unknown Object (File)
Oct 27 2024, 4:34 PM
Unknown Object (File)
Oct 1 2024, 2:54 AM
Unknown Object (File)
Sep 27 2024, 10:57 PM
View All 93 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
varun
• jon
Commits
rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config
Summary
Test Plan

cargo run - should start with default localstack endpoint (LOCALSTACK_ENDPOINT env is set by Nix). Default HTTP port is 50055.
The --http-port and --localstack-endpoint arguments do override the defaults.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 12 2023, 12:05 AM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 12 2023, 12:05 AM
Herald added a subscriber: ashoat. · View Herald Transcript
bartek added a child revision: D9139: [feature-flags] Use default HTTP port for deployments.Sep 12 2023, 12:13 AM
bartek updated this revision to Diff 30950.Sep 12 2023, 12:21 AM

Fix --http-port

bartek published this revision for review.Sep 12 2023, 12:22 AM
bartek added inline comments.
services/feature-flags/Dockerfile
35–36 ↗(On Diff #30950)

This gets addressed in the next diff (D9139)
because it requires a new deployment

Harbormaster completed remote builds in B22511: Diff 30948.Sep 12 2023, 12:24 AM
michal accepted this revision.Sep 12 2023, 12:27 AM
This revision is now accepted and ready to land.Sep 12 2023, 12:27 AM
Harbormaster completed remote builds in B22513: Diff 30950.Sep 12 2023, 12:39 AM
Closed by commit rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config (authored by bartek). · Explain WhySep 12 2023, 10:59 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config.

Revision Contents
Changeset List

PathSize
services/
feature-flags/
3 lines
src/
31 lines
4 lines
6 lines

Diff 30948

View Options

services/feature-flags/Dockerfile

Loading...
View Options

services/feature-flags/src/config.rs

Loading...
View Options

services/feature-flags/src/constants.rs

Loading...
View Options

services/feature-flags/src/service.rs

Loading...