We don't rely on specific websocket stream type, so this can be made generic.
This will be used in the next diff, where we will change TcpStream to a different type.
Depends on D9155
Details
Details
Tunnelbroker still builds, integration tests pass.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/tunnelbroker/src/websockets/mod.rs | ||
|---|---|---|
| 110 ↗ | (On Diff #30990) | These are traits that all socket stream types implement |
Comment Actions
Is generic-ness of this is going to be helpful in the future? Or is it going to be always HyperWebsocket under the hood? Because in that case we should just remove the generics and use HyperWebsocket directly
Comment Actions
It's not HyperWebsocket but rather a type gathered from hyper_websocket.await.split(). Alternatively, we could simply hardcode WebSocketStream<Upgraded> which is the exact type returned by this fn, but I'm not a fan because such hardcoding is the reason I had to do this change.
Perhaps we can do better, but refactoring is not my goal here.