[tunnelbroker] Allow configuring AMQP credentials
ClosedPublic
Actions

Authored by bartek on Sep 12 2023, 1:43 PM.

Details

Reviewers

kamil
michal
varun
• jon

Commits

rCOMMdd596a2b60c5: [tunnelbroker] Allow configuring AMQP credentials

Summary

We need a way to provide RabbitMQ credentials, without providing them in AMQP URI, since AWS doesn't expose authenticated URI.
Also, made AMQP URI configurable via env vars

Test Plan

Ran external RabbitMQ with custom credentials and configured tunnelbroker using environment variables

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 12 2023, 1:43 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 12 2023, 1:43 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D9155: [tunnelbroker] Don't listen on localhost only.Sep 12 2023, 1:45 PM

bartek published this revision for review.Sep 12 2023, 2:02 PM

bartek added inline comments.

services/tunnelbroker/src/amqp.rs
24 ↗	(On Diff #30987)	Clippy fix

Harbormaster completed remote builds in B22541: Diff 30987.Sep 12 2023, 2:03 PM

michal added inline comments.Sep 13 2023, 12:54 AM

services/tunnelbroker/src/amqp.rs
23 ↗	(On Diff #30987)	Just making sure - this won't print the env-provided credentials right?
services/tunnelbroker/src/config.rs
19 ↗	(On Diff #30987)	Can we do something similar to `reqwest::Url`, and remove the `expect` in `connect`?

bartek added inline comments.Sep 13 2023, 3:51 AM

services/tunnelbroker/src/amqp.rs
23 ↗	(On Diff #30987)	No, it won't
services/tunnelbroker/src/config.rs
19 ↗	(On Diff #30987)	We could, the only problem is that this type doesn't implement `Display` so we cannot easily log it.