Page MenuHomePhabricator

[tunnelbroker] Allow configuring AMQP credentials
ClosedPublic

Authored by bartek on Sep 12 2023, 1:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 9:10 AM
Unknown Object (File)
Tue, Oct 22, 9:10 AM
Unknown Object (File)
Tue, Oct 22, 9:09 AM
Unknown Object (File)
Tue, Oct 22, 5:04 AM
Unknown Object (File)
Sat, Oct 12, 3:45 AM
Unknown Object (File)
Oct 2 2024, 10:57 PM
Unknown Object (File)
Sep 25 2024, 11:33 PM
Unknown Object (File)
Sep 15 2024, 1:38 PM
Subscribers

Details

Summary

We need a way to provide RabbitMQ credentials, without providing them in AMQP URI, since AWS doesn't expose authenticated URI.
Also, made AMQP URI configurable via env vars

Test Plan

Ran external RabbitMQ with custom credentials and configured tunnelbroker using environment variables

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 12 2023, 2:02 PM
bartek added inline comments.
services/tunnelbroker/src/amqp.rs
24

Clippy fix

services/tunnelbroker/src/amqp.rs
23

Just making sure - this won't print the env-provided credentials right?

services/tunnelbroker/src/config.rs
19

Can we do something similar to reqwest::Url, and remove the expect in connect?

services/tunnelbroker/src/amqp.rs
23

No, it won't

services/tunnelbroker/src/config.rs
19

We could, the only problem is that this type doesn't implement Display so we cannot easily log it.

This revision is now accepted and ready to land.Sep 13 2023, 5:44 AM