Page MenuHomePhabricator

[CommCoreModule] capture primitive parameter by value
ClosedPublic

Authored by kamil on Sep 14 2023, 1:10 AM.
Tags
None
Referenced Files
F3522512: D9197.id31128.diff
Mon, Dec 23, 6:54 AM
F3521211: D9197.diff
Mon, Dec 23, 2:41 AM
Unknown Object (File)
Nov 8 2024, 8:12 AM
Unknown Object (File)
Nov 8 2024, 7:09 AM
Unknown Object (File)
Oct 28 2024, 9:47 AM
Unknown Object (File)
Oct 27 2024, 4:09 PM
Unknown Object (File)
Oct 1 2024, 3:56 AM
Unknown Object (File)
Sep 27 2024, 11:27 PM
Subscribers

Details

Summary

Fixes regression introduced in D8887.

This is a solution for ENG-4926.

When the code gets to run, the outer function generateRandomString may have already returned. This means that size might have been destroyed, and there is an undefined reference. That's why this function generates backupID with length 0 and as an effect causes Argon2 to throw salt too short.

On dev everything worked, everything happens only on prod when code is more optimized.

I also added casting to the correct type.

Test Plan

Test upload protocol in Release mode.

Diff Detail

Repository
rCOMM Comm
Branch
fix-backup
Lint
No Lint Coverage
Unit
No Test Coverage