Page MenuHomePhabricator

[terraform] Add Tunnelbroker
ClosedPublic

Authored by bartek on Sep 12 2023, 2:32 PM.
Tags
None
Referenced Files
F3153756: D9165.id31007.diff
Tue, Nov 5, 6:33 AM
F3152654: D9165.diff
Tue, Nov 5, 4:38 AM
Unknown Object (File)
Mon, Nov 4, 6:01 AM
Unknown Object (File)
Sun, Oct 27, 3:57 AM
Unknown Object (File)
Tue, Oct 22, 9:10 AM
Unknown Object (File)
Tue, Oct 22, 9:10 AM
Unknown Object (File)
Tue, Oct 22, 9:10 AM
Unknown Object (File)
Tue, Oct 22, 9:09 AM
Subscribers

Details

Summary

Terraform configuration from Tunnelbroker.

RabbitMQ docs: terraform resource, AWS docs.

The service is mostly copy-paste from other services

Depends on D9160, D9162

Test Plan

Created a Docker image from the stack and tested deployment on staging.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 12 2023, 2:37 PM
bartek added inline comments.
services/terraform/remote/service_tunnelbroker.tf
75 ↗(On Diff #31007)

This is to make plan difference nice - otherwise the whole jsonencode() block is made sensitive. We don't expose it anywhere so it's safe to do this.

Would it make sense to add apply_immediately (at least for staging)? If I understand the documentation correctly, currently if we make changes to the user (or add broker configuration) we would have to reboot rabbitmq manually?

services/terraform/remote/service_tunnelbroker.tf
22 ↗(On Diff #31007)

Kinda unrelated but it might make sense to pin the rabbitmq version in the docker-compose to match this

23 ↗(On Diff #31007)

Could we use micro for now?

This revision is now accepted and ready to land.Sep 13 2023, 7:02 AM

Would it make sense to add apply_immediately (at least for staging)? If I understand the documentation correctly, currently if we make changes to the user (or add broker configuration) we would have to reboot rabbitmq manually?

Yes, that's a good idea. We shouldn't do it for prod but for staging it's okay. I'll do this

services/terraform/remote/service_tunnelbroker.tf
22 ↗(On Diff #31007)

Good idea

23 ↗(On Diff #31007)

Micro isn't production ready (according to this table), but we can save some $ on staging

This revision was automatically updated to reflect the committed changes.