Page MenuHomePhabricator

[native] Memoize `ThreadAncestorsLabel`
ClosedPublic

Authored by atul on Sep 14 2023, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 1, 9:50 PM
Unknown Object (File)
Tue, Oct 1, 9:05 PM
Unknown Object (File)
Tue, Oct 1, 9:05 PM
Unknown Object (File)
Tue, Oct 1, 9:05 PM
Unknown Object (File)
Tue, Oct 1, 8:59 PM
Unknown Object (File)
Tue, Sep 10, 12:07 PM
Unknown Object (File)
Aug 29 2024, 12:28 AM
Unknown Object (File)
Aug 29 2024, 12:28 AM
Subscribers

Details

Summary

Looking at the profiler flamegraph for the "navigate to thread w/ varun" flow, there are a lot of ThreadAncestorsLabel "slivers" that seem like they might be causing other things to re-render? Unfortunately the profiler isn't super clear so I'm kind of memoizing this on a whim tbh.


Depends on D9212

Test Plan

ThreadAncestorsLabel continues to look as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage