[keyserver] Add ignorePermissions option to deleteThread
ClosedPublic
Actions

Authored by ashoat on Sep 19 2023, 1:01 PM.

Details

Reviewers

atul
rohan
inka

Commits

rCOMMc4344888e795: [keyserver] Add ignorePermissions option to deleteThread

Summary

This is needed in the following diff so that we can call deleteThread from a migrations context, where we use a viewer that otherwise doesn't have permissions to delete any thread (createScriptViewer(bots.commbot.userID)).

I modeled it after the equivalent permission in updateThread.

Test Plan

Before this diff, the following diff errored with an invalid_credentials error. After this diff, it no longer does.

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/jacek

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 19 2023, 1:01 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 19 2023, 1:02 PM

ashoat added a child revision: D9230: [keyserver] Delete sidebars created from pinned message robotexts.Sep 19 2023, 1:05 PM

Flow

Harbormaster failed remote builds in B22734: Diff 31272!Sep 19 2023, 1:17 PM

ashoat published this revision for review.Sep 19 2023, 1:31 PM

Harbormaster completed remote builds in B22737: Diff 31275.Sep 19 2023, 1:34 PM

atul accepted this revision.Sep 19 2023, 1:35 PM

This revision is now accepted and ready to land.Sep 19 2023, 1:35 PM

Closed by commit rCOMMc4344888e795: [keyserver] Add ignorePermissions option to deleteThread (authored by ashoat). · Explain WhySep 19 2023, 1:42 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc4344888e795: [keyserver] Add ignorePermissions option to deleteThread.

ashoat mentioned this in D9234: [keyserver] Skip early exit in deleteThread if ignorePermissions.Sep 19 2023, 2:30 PM

ashoat mentioned this in rCOMMd587cc151c26: [keyserver] Skip early exit in deleteThread if ignorePermissions.Sep 20 2023, 5:28 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

deleters/

thread-deleters.js

9 lines

Diff 31272

View Options

keyserver/src/deleters/thread-deleters.js

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines	switch (this->state) {
case State::DATA_CHUNKS: {		case State::DATA_CHUNKS: {
// TODO initialize blob client reactor		// TODO initialize blob client reactor
if (ServiceBlobClient::getInstance().putReactor == nullptr) {		if (ServiceBlobClient::getInstance().putReactor == nullptr) {
throw std::runtime_error(		throw std::runtime_error(
"blob client reactor has not been initialized");		"blob client reactor has not been initialized");
}		}

ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(		ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
request.newcompactionchunk());		std::make_unique<std::string>(
		std::move(*request.mutable_newcompactionchunk())));

return nullptr;		return nullptr;
}		}
}		}
throw std::runtime_error("new backup - invalid state");		throw std::runtime_error("new backup - invalid state");
}		}

void CreateNewBackupReactor::doneCallback() {		void CreateNewBackupReactor::doneCallback() {
ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk("");		ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
		std::make_unique<std::string>(""));
}		}

} // namespace reactor		} // namespace reactor
} // namespace network		} // namespace network
} // namespace comm		} // namespace comm

[keyserver] Add ignorePermissions option to deleteThreadClosedPublicActions