[keyserver] Move sidebar-of-sidebar check earlier in createThread
ClosedPublic
Actions

Authored by ashoat on Sep 19 2023, 1:09 PM.

Details

Reviewers

atul
rohan
inka

Commits

rCOMM47a6b495b17c: [keyserver] Move sidebar-of-sidebar check earlier in createThread

Summary

This change should be a no-op. Just moving a check earlier so we can have everything in one place.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/jacek

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 19 2023, 1:09 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 19 2023, 1:09 PM

Rebase

ashoat added a parent revision: D9230: [keyserver] Delete sidebars created from pinned message robotexts.Sep 19 2023, 1:23 PM

Harbormaster failed remote builds in B22736: Diff 31274!Sep 19 2023, 1:23 PM

ashoat added a child revision: D9232: [keyserver] Prevent creation of sidebars from pinned message robotext.Sep 19 2023, 1:24 PM

ashoat published this revision for review.Sep 19 2023, 1:32 PM

Harbormaster completed remote builds in B22739: Diff 31277.Sep 19 2023, 1:36 PM

atul accepted this revision.Sep 19 2023, 1:39 PM

This revision is now accepted and ready to land.Sep 19 2023, 1:39 PM

Closed by commit rCOMM47a6b495b17c: [keyserver] Move sidebar-of-sidebar check earlier in createThread (authored by ashoat). · Explain WhySep 19 2023, 1:42 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM47a6b495b17c: [keyserver] Move sidebar-of-sidebar check earlier in createThread.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

thread-creator.js

5 lines

Diff 31274

View Options

keyserver/src/creators/thread-creator.js

[keyserver] Move sidebar-of-sidebar check earlier in createThreadClosedPublicActions