Page MenuHomePhabricator
Differential D9375

[native] introduce UserProfileBottomSheetNavigator
ClosedPublic
Actions

Authored by ginsu on Oct 5 2023, 11:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 1:53 PM
Unknown Object (File)
Sun, Nov 17, 11:40 AM
Unknown Object (File)
Fri, Nov 15, 9:22 AM
Unknown Object (File)
Fri, Nov 8, 5:26 AM
Unknown Object (File)
Fri, Nov 8, 12:48 AM
Unknown Object (File)
Thu, Nov 7, 10:40 PM
Unknown Object (File)
Thu, Nov 7, 10:30 PM
Unknown Object (File)
Thu, Nov 7, 10:15 PM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM192a8528d8a4: [native] introduce UserProfileBottomSheetNavigator
Summary

In order to navigate to User Profile Avatar Modal from our user profile bottom sheet we need to introduce a new overlay navigator (this should be an overlay navigator since we want to layer the User Profile Avatar Modal on top of the User Profile Bottom sheet)

This is step 3 in the list below
Outlined below are the steps I will take in this stack (each point here will be it's own diff):

  1. Replace out of box BottomSheetModal with basic BottomSheet (Unfortunately, BottomSheetModal does not play nice with nested navigator)
  2. Polish up the BottomSheetBackdrop animation
  3. Introduce User Profile Bottom Sheet Navigators (this is so we can navigate to User Profile Avatar Modal from the User Profile Bottom Sheet)
  4. Introduce the User Profile Avatar Modal component and all the necessary things (like route names) that we will need to navigate to this new screen
  5. Factor out the User Avatar component in UserProfile into it's own separate component to keep things better organized

Depends on D9374

Test Plan

Confirmed that I was able to navigate to the user profile bottom sheet with this new nested navigator and I was able to navigate to the User Profile Avatar (which will be introduced in a subsequent diff)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 5 2023, 11:54 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 11:54 AM
ginsu updated this revision to Diff 31692.Oct 5 2023, 11:59 AM

update

ginsu edited the summary of this revision. (Show Details)Oct 5 2023, 12:09 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F791813: Screen Recording 2023-10-05 at 3.09.23 PM.mov. (Show Details)
Harbormaster completed remote builds in B23011: Diff 31691.Oct 5 2023, 12:12 PM
Harbormaster completed remote builds in B23012: Diff 31692.Oct 5 2023, 12:16 PM
ginsu requested review of this revision.Oct 5 2023, 12:16 PM
ginsu updated this revision to Diff 31693.Oct 5 2023, 12:16 PM
ginsu edited the test plan for this revision. (Show Details)

update

ginsu added inline comments.Oct 5 2023, 12:19 PM
native/user-profile/user-profile-bottom-sheet.react.js
39 ↗(On Diff #31693)

Now that we are nesting navigators, we want to use goBack so that the parent (root) navigator will handle brining the user back to the screen they were on before opening the user profile

https://reactnavigation.org/docs/nesting-navigators/#navigation-actions-are-handled-by-current-navigator-and-bubble-up-if-couldnt-be-handled

ginsu edited the summary of this revision. (Show Details)Oct 5 2023, 12:24 PM
ginsu added a parent revision: D9374: [native] fix BottomSheetBackdrop animation.
Harbormaster completed remote builds in B23013: Diff 31693.Oct 5 2023, 12:36 PM
ginsu added a child revision: D9376: [native] introduce UserProfileAvatarModal.Oct 5 2023, 12:36 PM
atul accepted this revision.Oct 5 2023, 4:20 PM
This revision is now accepted and ready to land.Oct 5 2023, 4:20 PM
ginsu updated this revision to Diff 31707.Oct 5 2023, 5:44 PM

rebase before landing

Harbormaster completed remote builds in B23027: Diff 31707.Oct 5 2023, 6:01 PM
ginsu updated this revision to Diff 31711.Oct 5 2023, 6:24 PM

rebase one more time before landing (had a phab error when attempted to recently land)

This revision was landed with ongoing or failed builds.Oct 5 2023, 6:38 PM
Closed by commit rCOMM192a8528d8a4: [native] introduce UserProfileBottomSheetNavigator (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM192a8528d8a4: [native] introduce UserProfileBottomSheetNavigator.
Harbormaster completed remote builds in B23031: Diff 31711.Oct 5 2023, 6:42 PM

Revision Contents
Changeset List

Diff 31711

View Options

native/navigation/root-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...
View Options

native/user-profile/user-profile-bottom-sheet-navigator.react.js

Loading...
View Options

native/user-profile/user-profile-bottom-sheet.react.js

Loading...