Page MenuHomePhabricator

[lib] Stop using Ethers.js client from Wagmi
ClosedPublic

Authored by ashoat on Oct 9 2023, 10:10 AM.
Tags
None
Referenced Files
F3359913: D9433.diff
Sun, Nov 24, 11:38 AM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:37 PM
Unknown Object (File)
Wed, Nov 20, 4:18 PM
Unknown Object (File)
Tue, Oct 29, 8:37 AM
Unknown Object (File)
Oct 19 2024, 4:20 AM
Unknown Object (File)
Oct 19 2024, 4:20 AM
Subscribers

Details

Summary

In Wagmi 1.0 they switch from Ethers.js to their in-house alternative Viem.

Our ENSCache code is built on Ethers.js. I'll consider migrating that to Viem, but for now the easiest thing is to decouple it.

Depends on D9432

Test Plan
  1. Confirm that ENS resolution still works on mobile and web by opening up the inbox when I have recently chatted with an ENS user, and confirm that they ENS name is displayed
  2. In combination with other diffs in the stack, I tested the following on both my local environment, and in a staging environment for my keyserver on comm.domains:
    • Mobile sign in with Rainbow wallet using Rainbow login
    • Mobile sign in with Rainbow wallet using WalletConnect login
    • Web sign in with Rainbow wallet using Rainbow login
    • Web sign in with Rainbow wallet using WalletConnect login
    • Web sign in with Metamask wallet

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul added inline comments.
landing/siwe.react.js
162–173

Probably some room for memoization here, but don't think performance is a concern w/ landing so makes sense to leave as is (more readable imo)


{F805831}

This revision is now accepted and ready to land.Oct 9 2023, 11:25 AM