Differential D9514

[lib/web/native] Show voiced_in_announcement_channels user-surfaced permission for all community types
ClosedPublic
Actions

Authored by rohan on Oct 17 2023, 9:29 AM.

Tags

None

Referenced Files

	F3325208: D9514.id32787.diff
	Wed, Nov 20, 5:19 AM

	F3323328: D9514.diff
	Wed, Nov 20, 3:34 AM

	Unknown Object (File)
	Thu, Nov 7, 9:19 PM

	Unknown Object (File)
	Thu, Nov 7, 9:19 PM

	Unknown Object (File)
	Thu, Nov 7, 9:19 PM

	Unknown Object (File)
	Thu, Nov 7, 9:19 PM

	Unknown Object (File)
	Thu, Nov 7, 9:19 PM

	Unknown Object (File)
	Thu, Nov 7, 9:18 PM

Subscribers

Details

Reviewers

atul
ginsu
ashoat

Commits

rCOMM3b4f16f477fe: [lib/web/native] Show voiced_in_announcement_channels user-surfaced permission…

Summary

When filtering out the user-surfaced 'voiced in announcement channels' permission when creating/editing roles, I didn't consider that we should always display this option because subchannels can be announcement threads. Now that they can be, I'm not going to filter this option out anymore.

Once ENG-5183 is resolved, this will mean that ticking this checkbox will allow users with the role to able to talk in all announcement channels (including the community root if it's an announcement thread).

This shouldn't require a migration since all it does is display the option in the permissions list client-side to be able to be toggled.

Resolves https://linear.app/comm/issue/ENG-5182/cant-see-voiced-in-announcement-channels-permission-when-editing-role

Depends on D9608

Test Plan

Please see the testing video below where I confirm in both announcement and non-announcement communities, the user-surfaced permission 'voiced in announcement channels' is shown:

Diff Detail

Repository

Branch

ENG-5182

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Oct 17 2023, 9:29 AM

Herald added subscribers: will, tomek. · View Herald TranscriptOct 17 2023, 9:29 AM

Harbormaster completed remote builds in B23293: Diff 32087.Oct 17 2023, 10:02 AM

rohan requested review of this revision.Oct 17 2023, 10:02 AM

rohan planned changes to this revision.Oct 17 2023, 10:44 AM

rohan edited the summary of this revision. (Show Details)Oct 26 2023, 9:22 AM

rohan added a parent revision: D9608: [native] Redux persist migration to remove incorrect permissions from threads.

rohan removed a parent revision: D9489: [keyserver/web] Enable announcement subchannel creation.

rohan requested review of this revision.Oct 26 2023, 9:27 AM

rohan edited the summary of this revision. (Show Details)

rohan edited the test plan for this revision. (Show Details)

atul accepted this revision.Oct 26 2023, 10:48 AM

This revision is now accepted and ready to land.Oct 26 2023, 10:48 AM

Rebase

Harbormaster completed remote builds in B23520: Diff 32439.Oct 26 2023, 11:25 AM

rohan added a child revision: D9675: [keyserver] Write a script to compare database role permissions match expectations.Nov 2 2023, 9:04 AM

rohan removed a child revision: D9675: [keyserver] Write a script to compare database role permissions match expectations.Nov 2 2023, 6:18 PM

rohan updated this revision to Diff 32787.Nov 6 2023, 8:03 AM

This comment was removed by rohan.

Revert changes (updated wrong diff)

Harbormaster completed remote builds in B23799: Diff 32788.Nov 6 2023, 8:24 AM

Harbormaster completed remote builds in B23798: Diff 32787.Nov 6 2023, 8:26 AM

rohan added a child revision: D9804: [lib] Include Voiced permission blob for announcement channels.Nov 9 2023, 8:19 AM

rohan added a child revision: D9897: [lib] Introduce getUniversalCommunityRootPermissionsBlob.Nov 17 2023, 7:09 AM

rohan removed a child revision: D9804: [lib] Include Voiced permission blob for announcement channels.

Rebase

Harbormaster completed remote builds in B24336: Diff 33493.Nov 22 2023, 8:00 AM

Closed by commit rCOMM3b4f16f477fe: [lib/web/native] Show voiced_in_announcement_channels user-surfaced permission… (authored by rohan). · Explain WhyNov 22 2023, 8:48 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM3b4f16f477fe: [lib/web/native] Show voiced_in_announcement_channels user-surfaced permission….

Revision Contents
Changeset List

Path

Size

lib/

utils/

34 lines

native/

roles/

create-roles-screen.react.js

13 lines

web/

roles/

create-roles-modal.react.js

19 lines

Diff 32087

lib/utils/role-utils.js

Loading...

native/roles/create-roles-screen.react.js

Loading...

web/roles/create-roles-modal.react.js

Loading...