Paths

Table of Contentst

Differential D9551

[lib/native] introduce useUpdateSystemTheme
ClosedPublic
Actions

Authored by ginsu on Oct 20 2023, 12:18 AM.

Tags

None

Referenced Files

	F3362312: D9551.id32244.diff
	Sun, Nov 24, 10:05 PM

	F3359456: D9551.diff
	Sun, Nov 24, 9:16 AM

	Unknown Object (File)
	Thu, Nov 21, 9:06 PM

	Unknown Object (File)
	Thu, Nov 21, 1:18 AM

	Unknown Object (File)
	Thu, Nov 14, 10:41 PM

	Unknown Object (File)
	Thu, Nov 14, 11:25 AM

	Unknown Object (File)
	Thu, Nov 14, 11:25 AM

	Unknown Object (File)
	Thu, Nov 14, 11:25 AM

View All 76 Files

Subscribers

Details

Reviewers

atul
inka
rohan

Commits

rCOMM736e75a1fd24: [lib/native] introduce useUpdateSystemTheme

Summary

Now that we want to bring updateThemeInfo redux actions/state into web as well there are several things we should lift from native into lib so that we can share them across both platforms. This diff lifts the common logic in ThemeHandler into a hook that can be consumed by each respective platform's ThemeHandler

Part of https://linear.app/comm/issue/ENG-4956/lift-any-necessary-shared-types-selectors-functions-for-storing-the

Depends on D9550

Test Plan

flow and confirmed that the logic in updateSystemTheme still works as expected

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 20 2023, 12:18 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 20 2023, 12:18 AM

ginsu edited the summary of this revision. (Show Details)Oct 20 2023, 12:19 AM

ginsu added reviewers: atul, inka, rohan.

ginsu added a parent revision: D9550: [lib/native/web] lift globalThemeInfo redux state into lib.

ginsu added inline comments.

native/themes/theme-handler.react.js
33	We need to use brackets for this callback to appease `flow`

ginsu added a child revision: D9552: [web] introduce redux persist migration for globalThemeInfo.Oct 20 2023, 12:30 AM

Harbormaster completed remote builds in B23394: Diff 32244.Oct 20 2023, 12:36 AM

ginsu requested review of this revision.Oct 20 2023, 12:36 AM

Seems like straightforward move from native to lib

This revision is now accepted and ready to land.Oct 20 2023, 10:45 AM

rebase before landing

This revision was landed with ongoing or failed builds.Oct 23 2023, 11:14 AM

Closed by commit rCOMM736e75a1fd24: [lib/native] introduce useUpdateSystemTheme (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM736e75a1fd24: [lib/native] introduce useUpdateSystemTheme.

Harbormaster completed remote builds in B23428: Diff 32320.Oct 23 2023, 11:19 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

37 lines

native/

themes/

theme-handler.react.js

33 lines

Diff 32244

lib/hooks/theme.js

Loading...

native/themes/theme-handler.react.js

Loading...