Page MenuHomePhabricator
Differential D9552

[web] introduce redux persist migration for globalThemeInfo
ClosedPublic
Actions

Authored by ginsu on Oct 20 2023, 12:26 AM.
Tags
None
Referenced Files
F3339856: D9552.diff
Thu, Nov 21, 8:48 PM
Unknown Object (File)
Wed, Nov 20, 12:23 PM
Unknown Object (File)
Tue, Nov 19, 10:06 PM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:23 AM
Unknown Object (File)
Thu, Nov 14, 11:00 AM
View All 75 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
rohan
inka
Commits
rCOMMabf2583fc896: [web] introduce redux persist migration for globalThemeInfo
Summary

We want to make sure that globalThemeInfo is persisted in redux. This diff creates a redux persist migration for globalThemeInfo

Part of https://linear.app/comm/issue/ENG-4958/update-theme-based-on-the-active-theme-redux-state

Depends on D9551

Test Plan

Please see the following below:

globalThemeInfo is in my redux state

Screenshot 2023-10-20 at 3.23.10 AM.png (2×3 px, 1005 KB)

globalThemeInfo being persisted

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 20 2023, 12:26 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 20 2023, 12:26 AM
ginsu edited the summary of this revision. (Show Details)Oct 20 2023, 12:30 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, inka.
ginsu added a parent revision: D9551: [lib/native] introduce useUpdateSystemTheme.
ginsu attached a referenced file: F826944: Screen Recording 2023-10-20 at 3.29.52 AM.mov. (Show Details)
ginsu attached a referenced file: F826943: Screenshot 2023-10-20 at 3.23.10 AM.png. (Show Details)
Harbormaster completed remote builds in B23395: Diff 32245.Oct 20 2023, 12:42 AM
ginsu requested review of this revision.Oct 20 2023, 12:42 AM
ginsu added a child revision: D9553: [lib/native] introduce useUpdateThemePreference.Oct 20 2023, 12:49 AM
atul accepted this revision.Oct 20 2023, 10:46 AM
This revision is now accepted and ready to land.Oct 20 2023, 10:46 AM
ginsu updated this revision to Diff 32321.Oct 23 2023, 11:02 AM

rebase before landing

This revision was landed with ongoing or failed builds.Oct 23 2023, 11:14 AM
Closed by commit rCOMMabf2583fc896: [web] introduce redux persist migration for globalThemeInfo (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMabf2583fc896: [web] introduce redux persist migration for globalThemeInfo.
Harbormaster completed remote builds in B23429: Diff 32321.Oct 23 2023, 11:20 AM

Revision Contents
Changeset List

PathSize
web/
redux/
8 lines

Diff 32245

View Options

web/redux/persist.js

Loading...