Paths

Table of Contentst

Differential D9444

[lib] Introduce a canBePinned boolean to message specs
ClosedPublic
Actions

Authored by rohan on Oct 10 2023, 8:38 AM.

Tags

None

Referenced Files

	F3386919: D9444.diff
	Fri, Nov 29, 6:46 AM

	Unknown Object (File)
	Wed, Nov 20, 4:38 PM

	Unknown Object (File)
	Wed, Nov 20, 4:38 PM

	Unknown Object (File)
	Wed, Nov 20, 4:37 PM

	Unknown Object (File)
	Wed, Nov 20, 4:18 PM

	Unknown Object (File)
	Tue, Nov 19, 9:07 PM

	Unknown Object (File)
	Oct 19 2024, 4:20 AM

	Unknown Object (File)
	Oct 19 2024, 4:20 AM

View All 57 Files

Subscribers

Details

Reviewers

atul
ginsu

Commits

rCOMM5d0f8bec7a3b: [lib] Introduce a canBePinned boolean to message specs

Summary

This diff introduces a canBePinned boolean to each of the message specs, isolating the 'source of truth' to the message specs. The next diff will have a function that will be able to read each of these, alongside unit tests and updating appropriate callsites.

Only composable message types can be pinned

Resolves https://linear.app/comm/issue/ENG-5213/introduce-a-canbepinned-boolean-to-message-specs

Depends on D9331

Test Plan

Ran flow for this diff, more thorough testing will be in the next diff

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Oct 10 2023, 8:38 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 10 2023, 8:38 AM

rohan edited the summary of this revision. (Show Details)Oct 10 2023, 8:39 AM

rohan added a child revision: D9445: [lib/web/native] Introduce isInvalidPinSource method that checks the messageSpec.canBePinned.Oct 10 2023, 8:45 AM

Harbormaster completed remote builds in B23150: Diff 31878.Oct 10 2023, 8:58 AM

rohan requested review of this revision.Oct 10 2023, 8:58 AM

rohan edited the summary of this revision. (Show Details)Oct 10 2023, 9:01 AM

This seems like a much cleaner and maintainable approach

This revision is now accepted and ready to land.Oct 16 2023, 4:52 PM

Closed by commit rCOMM5d0f8bec7a3b: [lib] Introduce a canBePinned boolean to message specs (authored by rohan). · Explain WhyOct 20 2023, 8:27 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM5d0f8bec7a3b: [lib] Introduce a canBePinned boolean to message specs.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

add-members-message-spec.js

2 lines

change-role-message-spec.js

2 lines

change-settings-message-spec.js

2 lines

create-entry-message-spec.js

2 lines

create-sidebar-message-spec.js

2 lines

create-sub-thread-message-spec.js

2 lines

create-thread-message-spec.js

2 lines

delete-entry-message-spec.js

2 lines

edit-entry-message-spec.js

2 lines

edit-message-spec.js

2 lines

join-thread-message-spec.js

2 lines

leave-thread-message-spec.js

2 lines

message-spec.js

1 line

multimedia-message-spec.js

2 lines

reaction-message-spec.js

2 lines

remove-members-message-spec.js

2 lines

restore-entry-message-spec.js

2 lines

sidebar-source-message-spec.js

2 lines

text-message-spec.js

2 lines

toggle-pin-message-spec.js

2 lines

unsupported-message-spec.js

2 lines

update-relationship-message-spec.js

2 lines

Diff 32255

lib/shared/messages/add-members-message-spec.js

Loading...

lib/shared/messages/change-role-message-spec.js

Loading...

lib/shared/messages/change-settings-message-spec.js

Loading...

lib/shared/messages/create-entry-message-spec.js

Loading...

lib/shared/messages/create-sidebar-message-spec.js

Loading...

lib/shared/messages/create-sub-thread-message-spec.js

Loading...

lib/shared/messages/create-thread-message-spec.js

Loading...

lib/shared/messages/delete-entry-message-spec.js

Loading...

lib/shared/messages/edit-entry-message-spec.js

Loading...

lib/shared/messages/edit-message-spec.js

Loading...

lib/shared/messages/join-thread-message-spec.js

Loading...

lib/shared/messages/leave-thread-message-spec.js

Loading...

lib/shared/messages/message-spec.js

Loading...

lib/shared/messages/multimedia-message-spec.js

Loading...

lib/shared/messages/reaction-message-spec.js

Loading...

lib/shared/messages/remove-members-message-spec.js

Loading...

lib/shared/messages/restore-entry-message-spec.js

Loading...

lib/shared/messages/sidebar-source-message-spec.js

Loading...

lib/shared/messages/text-message-spec.js

Loading...

lib/shared/messages/toggle-pin-message-spec.js

Loading...

lib/shared/messages/unsupported-message-spec.js

Loading...

lib/shared/messages/update-relationship-message-spec.js

Loading...