[native] implement keyserver list ui
ClosedPublic
Actions

Authored by ginsu on Oct 31 2023, 1:17 AM.

Details

Reviewers

rohan
michal
inka

Commits

rCOMM9ab651cf98bb: [native] implement keyserver list ui

Summary

This diff introduces the UI for the keyserver selection list. For context here is a screenshot of the designs (please note, that elements like the connection indicator will be introduced in subsquent diffs)

Screenshot 2023-10-31 at 4.13.49 AM.png (1×764 px, 96 KB)

Linear task: https://linear.app/comm/issue/ENG-4913/update-keyserver-list-ui

Depends on D9641

Test Plan

Please see the screenshots below (the second keyserver is just a test "dummy" keyserver I added to the keyserver store when testing the add keyserver flow)

Screenshot 2023-10-31 at 4.22.48 AM.png (1×944 px, 528 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 31 2023, 1:17 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 31 2023, 1:17 AM

ginsu edited the summary of this revision. (Show Details)Oct 31 2023, 1:19 AM

ginsu added reviewers: rohan, michal, inka.

ginsu added a parent revision: D9641: [lib] introduce selected keyservers selector.

update

ginsu added inline comments.Oct 31 2023, 1:23 AM

native/profile/profile.react.js
70 ↗	(On Diff #32520)	Snuck this change in this diff after taking a second look at the designs are realizing this should say "Keyservers"

ginsu edited the summary of this revision. (Show Details)Oct 31 2023, 1:24 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F843799: Screenshot 2023-10-31 at 4.22.48 AM.png. (Show Details)

ginsu attached a referenced file: F843798: Screenshot 2023-10-31 at 4.13.49 AM.png. (Show Details)

ginsu added a child revision: D9643: [native] display connnection state of keyserver.Oct 31 2023, 1:35 AM

Harbormaster completed remote builds in B23584: Diff 32519.Oct 31 2023, 1:35 AM

Harbormaster completed remote builds in B23585: Diff 32520.Oct 31 2023, 1:58 AM

ginsu requested review of this revision.Oct 31 2023, 1:58 AM

rohan accepted this revision.Nov 2 2023, 9:43 AM

rohan added inline comments.

native/profile/keyserver-selection-list.react.js
62 ↗	(On Diff #32520)	Are you able to add some spacing on top of this label? Seems like it's there in the designs but not in the implementation

This revision is now accepted and ready to land.Nov 2 2023, 9:43 AM

ashoat added inline comments.Nov 2 2023, 10:55 AM

native/profile/keyserver-selection-list.react.js
62 ↗	(On Diff #32520)	We should try to keep the "panel" design consistent – if we make a change to it here, that change should be applied across all panels

ginsu added inline comments.Nov 2 2023, 11:50 AM

native/profile/keyserver-selection-list.react.js
62 ↗	(On Diff #32520)	Thanks for this catch @rohan, I will update the spacing at the top of the label and make sure that it is consistent with other user settings panels we have in our app. Here is a preview: