[lib] Get rid of SentencePrefixSearchIndex.entries
ClosedPublic
Actions

Authored by ashoat on Oct 31 2023, 5:02 AM.

Details

Reviewers

tomek
atul
inka
rohan

Commits

rCOMM5153064608b8: [lib] Get rid of SentencePrefixSearchIndex.entries

Summary

With PrefixTree we no longer need to special-case this.

Test Plan

I went to a community in my local environment and typed a single "@" character. I made sure the options displayed before/after were the same

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 31 2023, 5:02 AM

Herald added a subscriber: will. · View Herald TranscriptOct 31 2023, 5:02 AM

ashoat added a child revision: D9647: [lib] Avoid unnecessary Set construction in RadixTree.getAllMatchingExactly.Oct 31 2023, 5:05 AM

ashoat published this revision for review.Oct 31 2023, 5:11 AM

Harbormaster completed remote builds in B23590: Diff 32531.Oct 31 2023, 5:23 AM

tomek accepted this revision.Oct 31 2023, 6:49 AM

This revision is now accepted and ready to land.Oct 31 2023, 6:49 AM

Closed by commit rCOMM5153064608b8: [lib] Get rid of SentencePrefixSearchIndex.entries (authored by ashoat). · Explain WhyOct 31 2023, 6:55 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5153064608b8: [lib] Get rid of SentencePrefixSearchIndex.entries.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

5 lines

sentence-prefix-search-index.js

4 lines

Diff 32531

View Options

lib/shared/mention-utils.js