Page MenuHomePhabricator
Differential D9669

[native] Support avatar uploads to blob service
ClosedPublic
Actions

Authored by bartek on Nov 1 2023, 1:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 5:51 PM
Unknown Object (File)
Sun, Dec 15, 5:51 PM
Unknown Object (File)
Sun, Dec 15, 5:51 PM
Unknown Object (File)
Sun, Dec 15, 5:51 PM
Unknown Object (File)
Sun, Dec 15, 5:51 PM
Unknown Object (File)
Sun, Dec 15, 5:49 PM
Unknown Object (File)
Sun, Dec 15, 5:28 PM
Unknown Object (File)
Wed, Dec 11, 5:03 PM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
ginsu
Commits
rCOMMec0bdaaca6d6: [native] Support avatar uploads to blob service
Summary

This diff enables avatar uploads to blob service on native. Modified the hook to conditionally use function that uploads avatar to blob service instead of keyserver. This is very similar to what we currently do with multimedia messages.

Depends on D9668

Test Plan

Similiar to D9170 test plan, but on native:

Tested on both user and thread avatars.
With the flag set to true, changed the avatar to an image and used TablePlus to verify MariaDB contents (this tests changes to D9168). Also, the avatar was then displayed correctly (which is more deeply tested in D9624 and D9668)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Nov 1 2023, 1:07 AM
bartek held this revision as a draft.
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 1 2023, 1:07 AM
Harbormaster completed remote builds in B23641: Diff 32589.Nov 1 2023, 1:39 AM
bartek published this revision for review.Nov 1 2023, 2:00 AM
atul accepted this revision.Nov 1 2023, 8:31 PM
This revision is now accepted and ready to land.Nov 1 2023, 8:31 PM
bartek updated this revision to Diff 32746.Nov 6 2023, 4:25 AM

Rebase

Harbormaster completed remote builds in B23784: Diff 32746.Nov 6 2023, 5:26 AM
bartek updated this revision to Diff 32843.Nov 7 2023, 12:15 AM

Rebase on multi-keyserver action update

bartek added a parent revision: D9738: [lib] Accept keyserver ID in blob service upload action.Nov 7 2023, 12:15 AM
Harbormaster failed remote builds in B23827: Diff 32843!Nov 7 2023, 12:31 AM
bartek updated this revision to Diff 32868.Nov 7 2023, 5:40 AM

Rebase on latest master

Harbormaster completed remote builds in B23850: Diff 32868.Nov 7 2023, 7:43 AM
bartek mentioned this in D9738: [lib] Accept keyserver ID in blob service upload action.Nov 8 2023, 3:33 AM
Closed by commit rCOMMec0bdaaca6d6: [native] Support avatar uploads to blob service (authored by bartek). · Explain WhyNov 9 2023, 11:09 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMec0bdaaca6d6: [native] Support avatar uploads to blob service.

Revision Contents
Changeset List

PathSize
native/
avatars/
98 lines

Diff 32868

View Options

native/avatars/avatar-hooks.js

Loading...