Page MenuHomePhabricator
Differential D9169

[lib] Add blob service upload avatar type validators
ClosedPublic
Actions

Authored by bartek on Sep 12 2023, 3:30 PM.
Tags
None
Referenced Files
F3756951: D9169.id32472.diff
Fri, Jan 10, 6:41 AM
F3754499: D9169.diff
Fri, Jan 10, 3:17 AM
Unknown Object (File)
Wed, Dec 25, 7:04 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM4664cc89d425: [lib] Add blob service upload avatar type validators
Summary

This diff adds avatar type validators for the encrypted-image avatars

Test Plan

Added unit tests. Also tested together with D9170

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• patryk created this revision.Sep 12 2023, 3:30 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 3:30 PM
Harbormaster failed remote builds in B22562: Diff 31011!Sep 12 2023, 3:46 PM
• patryk edited the summary of this revision. (Show Details)Sep 13 2023, 8:00 AM
• patryk edited the test plan for this revision. (Show Details)
bartek commandeered this revision.Oct 27 2023, 10:15 AM
bartek edited reviewers, added: • patryk; removed: bartek.
bartek updated this revision to Diff 32472.Oct 27 2023, 10:19 AM
bartek edited the summary of this revision. (Show Details)

Rebase and some rework

bartek added a parent revision: D9168: [keyserver][lib] Support new avatar type for encrypted images.Oct 27 2023, 10:20 AM
bartek added a child revision: D9170: [web] Support avatar uploads to blob service.
Harbormaster failed remote builds in B23547: Diff 32472!Oct 27 2023, 10:36 AM
bartek added a child revision: D9624: [web] Display encrypted image avatars.Oct 30 2023, 3:10 AM
bartek updated this revision to Diff 32481.Oct 30 2023, 3:15 AM

Fix broken rebase

bartek edited the summary of this revision. (Show Details)Oct 30 2023, 3:29 AM
bartek edited the test plan for this revision. (Show Details)
bartek edited reviewers, added: ginsu; removed: • patryk.
Harbormaster failed remote builds in B23554: Diff 32481!Oct 30 2023, 4:03 AM
bartek published this revision for review.Oct 30 2023, 4:35 AM
Harbormaster completed remote builds in B23554: Diff 32481.Oct 30 2023, 5:28 AM
bartek removed a child revision: D9170: [web] Support avatar uploads to blob service.Nov 1 2023, 1:02 AM
atul accepted this revision.Nov 1 2023, 7:16 PM

Looks good, thanks for adding the unit tests

This revision is now accepted and ready to land.Nov 1 2023, 7:16 PM
bartek updated this revision to Diff 32742.Nov 6 2023, 4:24 AM

Rebase

Harbormaster completed remote builds in B23780: Diff 32742.Nov 6 2023, 4:51 AM
bartek updated this revision to Diff 32863.Nov 7 2023, 5:38 AM

Rebase on latest master

Harbormaster failed remote builds in B23845: Diff 32863!Nov 7 2023, 6:57 AM
This revision was landed with ongoing or failed builds.Nov 9 2023, 11:08 PM
Closed by commit rCOMM4664cc89d425: [lib] Add blob service upload avatar type validators (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM4664cc89d425: [lib] Add blob service upload avatar type validators.

Revision Contents
Changeset List

PathSize
lib/
types/
7 lines
utils/
8 lines
30 lines

Diff 33048

View Options

lib/types/avatar-types.js

Loading...
View Options

lib/utils/avatar-utils.js

Loading...
View Options

lib/utils/avatar-utils.test.js

Loading...