[lib] introduce removeKeyserverActionType condition to keyserver reducer
ClosedPublic
Actions

Authored by ginsu on Nov 10 2023, 11:59 AM.

Details

Reviewers

inka
rohan
michal

Commits

rCOMMb89136d8d288: [lib] introduce removeKeyserverActionType condition to keyserver reducer

Summary

This diff adds the condition for removing a keyserver from the keyserver store. I am aware that at this time @inka currently has D9750 and D9820 up which refactor this reducer, and this diff might cause some merge conflicts. @inka and I have been communicating throughout this process and I will make @inka a blocking reviewer for this as well.

Linear task: https://linear.app/comm/issue/ENG-5465/introduce-remove-keyserver-action-case-to-reducekeyserver-function

Depends D9828

Test Plan

Confirmed that I was able to remove a keyserver from the keyserver store

Screenshot 2023-11-13 at 4.19.22 PM.png (1×1 px, 575 KB)

Screenshot 2023-11-13 at 4.18.52 PM.png (1×1 px, 573 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 10 2023, 11:59 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 11:59 AM

ginsu retitled this revision from [lib] introduce removeKeyserverActionType condition to keyserver reducer to DRAFT [lib] introduce removeKeyserverActionType condition to keyserver reducer.Nov 10 2023, 12:01 PM

ginsu edited the summary of this revision. (Show Details)

ginsu added reviewers: inka, michal, rohan.

ginsu edited the summary of this revision. (Show Details)

ginsu removed reviewers: michal, rohan.Nov 10 2023, 12:04 PM

Harbormaster completed remote builds in B24007: Diff 33081.Nov 10 2023, 12:20 PM

ginsu requested review of this revision.Nov 10 2023, 12:20 PM

rebase

ginsu edited the summary of this revision. (Show Details)Nov 13 2023, 1:20 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: rohan, michal. ginsu added 1 blocking reviewer(s): inka.

ginsu attached a referenced file: F873223: Screenshot 2023-11-13 at 4.18.52 PM.png. (Show Details)

ginsu attached a referenced file: F873225: Screenshot 2023-11-13 at 4.19.22 PM.png. (Show Details)

ginsu retitled this revision from DRAFT [lib] introduce removeKeyserverActionType condition to keyserver reducer to [lib] introduce removeKeyserverActionType condition to keyserver reducer.

Harbormaster completed remote builds in B24058: Diff 33148.Nov 13 2023, 1:45 PM

ashoat added inline comments.Nov 13 2023, 2:03 PM

lib/reducers/keyserver-reducer.js
55–70	Try this: const { [action.payload.keyserverAdminUserID]: _, ...rest } = state.keyserverInfos; return { ...state, keyserverInfos: rest };
55–70	Actually make sure to `[(action.payload.keyserverAdminUserID: string)]`... new version of Flow feels strongly about that typehint