Page MenuHomePhabricator
Differential D9828

[native] introduce temp onPressDisconnectKeyserver callback
ClosedPublic
Actions

Authored by ginsu on Nov 10 2023, 11:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 8:29 AM
Unknown Object (File)
Mon, Apr 29, 9:31 AM
Unknown Object (File)
Apr 15 2024, 12:09 AM
Unknown Object (File)
Apr 12 2024, 6:01 PM
Unknown Object (File)
Apr 10 2024, 12:24 PM
Unknown Object (File)
Apr 6 2024, 10:01 AM
Unknown Object (File)
Apr 5 2024, 10:46 AM
Unknown Object (File)
Apr 5 2024, 3:41 AM
View All 26 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
inka
michal
rohan
ashoat
Commits
rCOMMb759ac739fef: [native] introduce temp onPressDisconnectKeyserver callback
Summary

As of Nov 2023, disconnecting from a keyserver is outside the scope of the keyserver selection screen. However, we currently have the UI for this already implemented so as a temporary solution this diff has the onPressDisconnectKeyserver callback display an alert to the user, informing them that this feature is not quite ready yet

Depends on D9826

Test Plan

Please see demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 10 2023, 11:27 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 11:27 AM
ginsu mentioned this in D9754: [native] introduce keyserver selection bottom sheet ui.Nov 10 2023, 11:29 AM
ginsu edited the summary of this revision. (Show Details)Nov 10 2023, 11:31 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, michal, rohan.
ginsu added a parent revision: D9826: [lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo.
ginsu attached a referenced file: F869303: Screen Recording 2023-11-10 at 2.31.25 PM.mov. (Show Details)
ginsu added inline comments.
native/profile/keyserver-selection-bottom-sheet.react.js
85–86 ↗(On Diff #33080)

This comment is intentional to signal to devs that this is just a temporary solution

ginsu mentioned this in D9829: [lib] introduce removeKeyserverActionType condition to keyserver reducer.Nov 10 2023, 12:01 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 10 2023, 12:29 PM
Harbormaster failed remote builds in B24006: Diff 33080!
ginsu requested review of this revision.Nov 10 2023, 12:29 PM
rohan accepted this revision.Nov 12 2023, 9:07 AM

Is the plan to make this keyserver selection screen available to everyone before disconnecting from keyservers is possible?

This revision is now accepted and ready to land.Nov 12 2023, 9:07 AM
ginsu added a child revision: D9830: [native] introduce functionality for onPressRemoveKeyserver callback.Nov 13 2023, 12:57 PM
inka added a reviewer: ashoat.Nov 13 2023, 11:53 PM

I'm not a native so I might be wrong, but this copy sounds odd to me. Wouldn't "Disconnecting from a keyserver is not ready yet" be more correct? Or "It is not yet possible to disconnect form a keyserver"?
This has to do with copy, so according to this notion dock @ashoat has to be added to review

This revision now requires review to proceed.Nov 13 2023, 11:53 PM
inka mentioned this in D9794: [native] update remove keyserver text based on connection status.Nov 14 2023, 12:20 AM
ashoat resigned from this revision.Nov 14 2023, 6:27 AM

Thanks @inka! In general I agree, but I think this copy won't be surfaced to users (right @ginsu?) so it's probably not that important. Correct me if I'm wrong though!

This revision is now accepted and ready to land.Nov 14 2023, 6:27 AM
ginsu added a comment.Nov 14 2023, 11:14 AM

this copy won't be surfaced to users

This entire interface is gated behind the useStaffCanSee so users won't be able to see this, but staff members/devs will

hook https://github.com/CommE2E/comm/blob/master/native/utils/staff-utils.js

ginsu updated this revision to Diff 33239.Nov 14 2023, 5:28 PM

rebase before landing

Harbormaster completed remote builds in B24132: Diff 33239.Nov 14 2023, 5:47 PM
Closed by commit rCOMMb759ac739fef: [native] introduce temp onPressDisconnectKeyserver callback (authored by ginsu). · Explain WhyNov 14 2023, 5:47 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb759ac739fef: [native] introduce temp onPressDisconnectKeyserver callback.
ginsu mentioned this in rCOMMb89136d8d288: [lib] introduce removeKeyserverActionType condition to keyserver reducer.Nov 14 2023, 5:49 PM

Revision Contents
Changeset List

PathSize
native/
profile/
14 lines

Diff 33245

View Options

native/profile/keyserver-selection-bottom-sheet.react.js

Loading...