Page MenuHomePhabricator
Differential D9830

[native] introduce functionality for onPressRemoveKeyserver callback
ClosedPublic
Actions

Authored by ginsu on Nov 10 2023, 12:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 8:29 AM
Unknown Object (File)
Sat, May 4, 12:45 PM
Unknown Object (File)
Thu, May 2, 9:55 AM
Unknown Object (File)
Tue, Apr 30, 1:17 AM
Unknown Object (File)
Apr 15 2024, 12:59 AM
Unknown Object (File)
Apr 13 2024, 1:13 AM
Unknown Object (File)
Apr 11 2024, 12:43 AM
Unknown Object (File)
Apr 5 2024, 3:40 AM
View All 29 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
inka
michal
rohan
Commits
rCOMMedc5a062bf93: [native] introduce functionality for onPressRemoveKeyserver callback
Summary

This diff introduces the user flow for when a user presses the remove keyserver button in the keyserver selection bottomsheet.

For context here are the designs for what the user flow should look like:

Screenshot 2023-11-10 at 3.16.36 PM.png (1×1 px, 291 KB)

Linear task: https://linear.app/comm/issue/ENG-5474/introduce-onpress-remove-selected-keyserver-function

Depends on D9828

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 10 2023, 12:15 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 12:15 PM
ginsu edited the summary of this revision. (Show Details)Nov 10 2023, 12:20 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, michal, rohan.
ginsu attached a referenced file: F869385: Screen Recording 2023-11-10 at 3.19.51 PM.mov. (Show Details)
ginsu attached a referenced file: F869380: Screenshot 2023-11-10 at 3.16.36 PM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)Nov 10 2023, 12:22 PM
ginsu published this revision for review.Nov 10 2023, 12:30 PM
Harbormaster completed remote builds in B24008: Diff 33082.Nov 10 2023, 12:45 PM
ashoat added inline comments.Nov 11 2023, 10:57 AM
native/profile/keyserver-selection-bottom-sheet.react.js
112 ↗(On Diff #33082)

Can you try to keep lines to 80 chars?

ginsu updated this revision to Diff 33146.Nov 13 2023, 12:55 PM

address @ashoat's comments

ginsu edited the summary of this revision. (Show Details)Nov 13 2023, 12:57 PM
ginsu added a parent revision: D9828: [native] introduce temp onPressDisconnectKeyserver callback.
Harbormaster completed remote builds in B24056: Diff 33146.Nov 13 2023, 1:24 PM
inka accepted this revision.Nov 14 2023, 12:44 AM
This revision is now accepted and ready to land.Nov 14 2023, 12:44 AM
ginsu updated this revision to Diff 33243.Nov 14 2023, 5:45 PM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 14 2023, 5:52 PM
Closed by commit rCOMMedc5a062bf93: [native] introduce functionality for onPressRemoveKeyserver callback (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMedc5a062bf93: [native] introduce functionality for onPressRemoveKeyserver callback.
Harbormaster completed remote builds in B24136: Diff 33243.Nov 14 2023, 6:47 PM

Revision Contents
Changeset List

PathSize
native/
profile/
34 lines

Diff 33247

View Options

native/profile/keyserver-selection-bottom-sheet.react.js

Loading...