Page MenuHomePhabricator
Differential D9847

[lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 2:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 9:18 AM
Unknown Object (File)
Mon, Dec 2, 11:09 AM
Unknown Object (File)
Sun, Dec 1, 1:22 AM
Unknown Object (File)
Sat, Nov 30, 12:47 PM
Unknown Object (File)
Sun, Nov 24, 10:25 PM
Unknown Object (File)
Nov 16 2024, 8:43 PM
Unknown Object (File)
Nov 16 2024, 8:43 PM
Unknown Object (File)
Nov 16 2024, 8:43 PM
View All 72 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM93f4eb08785d: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`
Summary

Similar to D9811, we're updating utilities in thread-utils to handle MinimallyEncodedThreadInfo where the change is as simple as updating fn signature.

Will now go through and handle the ones that require more refactoring/branching/etc. Specifically:

  • threadUIName
  • checkIfDefaultMembers
  • patchThreadInfoToIncludeMentionedMembersOfParent
  • useRoleUserSurfacedPermissions

Depends on D9846

Test Plan

Entirely flow for now.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D9847 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 13 2023, 2:13 PM
atul added inline comments.Nov 13 2023, 2:15 PM
lib/types/thread-types.js
51–55 ↗(On Diff #33150)

Spreading MemberInfo causes fields to being "writeable."

This became an issue because I wrapped type definition of MinimallyEncodedRelativeMemberInfo in $ReadOnly<> which caused some flow issues.

I figure this is more "correct" anyways given we prefer read-only where possible?

atul published this revision for review.Nov 13 2023, 2:15 PM
atul added a child revision: D9848: [lib] Update `threadUIName` to handle `MinimallyEncodedThreadInfo`.Nov 13 2023, 2:29 PM
ashoat accepted this revision.Nov 13 2023, 2:31 PM
This revision is now accepted and ready to land.Nov 13 2023, 2:31 PM
Harbormaster completed remote builds in B24060: Diff 33150.Nov 13 2023, 2:33 PM
atul updated this revision to Diff 33173.Nov 13 2023, 3:01 PM

rebase and land

This revision was landed with ongoing or failed builds.Nov 13 2023, 3:02 PM
Closed by commit rCOMM93f4eb08785d: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM93f4eb08785d: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`.
Harbormaster completed remote builds in B24075: Diff 33173.Nov 13 2023, 4:46 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
205 lines
types/
4 lines

Diff 33173

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/thread-types.js

Loading...