Page MenuHomePhabricator

[keyserver][lib] Update freshMessageStore to return currentAsOf for all keyservers
ClosedPublic

Authored by inka on Nov 14 2023, 2:18 AM.
Tags
None
Referenced Files
F3370177: D9879.diff
Tue, Nov 26, 1:16 AM
Unknown Object (File)
Sun, Nov 24, 4:35 PM
Unknown Object (File)
Mon, Oct 28, 12:14 AM
Unknown Object (File)
Oct 15 2024, 5:16 PM
Unknown Object (File)
Oct 5 2024, 7:15 PM
Unknown Object (File)
Sep 28 2024, 3:23 AM
Unknown Object (File)
Sep 28 2024, 3:23 AM
Unknown Object (File)
Sep 28 2024, 3:22 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-5722/update-freshmessagestore-function
freshMessageStore should return currentAsOf for all keyservers

Test Plan

Tested that after the setInitialReduxState action the currentAsOf field is correct - a "map" from keyserver id to number.
This tests this function, because freshMessageStore is called by the keyserver in getInitialReduxStateResponder which returns the initial state. The states from all keyservers are then merged in getInitialReduxState, and the returnd value is dispatched with setInitialReduxState action.
I also logged to the console the value returned from freshMessageStore in getInitialReduxStateResponder and checked that it is correct.
I also logged in and checked that the currentAsOf in messageStore is correct after logInActionTypes.success

Diff Detail

Repository
rCOMM Comm
Branch
inka/reducers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Nov 14 2023, 2:38 AM
This revision is now accepted and ready to land.Nov 14 2023, 7:04 AM
keyserver/src/responders/redux-state-responders.js
171 ↗(On Diff #33508)

For future reference, the new Flow requires an annotation here

keyserver/src/responders/redux-state-responders.js
171 ↗(On Diff #33508)

Actually, hmmm... I guess this isn't always required, as I'm not seeing any errors after rebasing. Sorry for the distraction!