Page MenuHomePhabricator
Differential D9815

[lib] Inline reduceConnectionInfo pt.2
ClosedPublic
Actions

Authored by inka on Nov 10 2023, 3:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 12:04 AM
Unknown Object (File)
Sun, Dec 15, 3:27 PM
Unknown Object (File)
Tue, Nov 26, 8:15 AM
Unknown Object (File)
Tue, Nov 26, 8:08 AM
Unknown Object (File)
Mon, Nov 25, 11:20 AM
Unknown Object (File)
Sun, Nov 24, 7:01 PM
Unknown Object (File)
Nov 22 2024, 6:20 PM
Unknown Object (File)
Nov 22 2024, 6:17 PM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMMcf7ad414cdde: [lib] Inline reduceConnectionInfo pt.2
Summary

issue: https://linear.app/comm/issue/ENG-5352/inline-reduceconnectioninfo
See the deleted file for how it worked before
The disconnected bar and with it the lateResponses logic will be reviewd again during ENG-4126 and ENG-4125. For now I'm refactoring them in a way that 1. doesn't break the old behaviour 2. Will be easier to refactor later on

Test Plan

Dispatched setNewSessionActionType, updateDisconnectedBarActionType, logOutActionTypes, setLateResponseActionType actions and checked that the state changes as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Nov 10 2023, 3:34 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 3:34 AM
inka updated this revision to Diff 33056.Nov 10 2023, 3:38 AM

Improve disconneted bar logic in case we want to use showDisconnectedBar for someting in the future, like for keyserver selection screen

inka added a parent revision: D9803: [lib] Inline reduceConnectionInfo pt.1.Nov 10 2023, 3:43 AM
Harbormaster completed remote builds in B23986: Diff 33055.Nov 10 2023, 3:52 AM
Harbormaster completed remote builds in B23987: Diff 33056.Nov 10 2023, 4:03 AM
inka requested review of this revision.Nov 10 2023, 4:03 AM
inka added a child revision: D9816: [lib] Inline reduceDeviceToken.Nov 10 2023, 4:27 AM
inka mentioned this in D9750: [lib] Refactor keyserver reducer pt.1.Nov 14 2023, 12:58 AM
inka updated this revision to Diff 33202.Nov 14 2023, 1:07 AM

Rebase over D9664 - remove all keyservers but Ashoat's keyserver on logout and delete account.

Harbormaster completed remote builds in B24102: Diff 33202.Nov 14 2023, 1:54 AM
michal accepted this revision.Nov 14 2023, 6:07 AM
This revision is now accepted and ready to land.Nov 14 2023, 6:07 AM
ginsu accepted this revision.Nov 14 2023, 11:08 AM
inka updated this revision to Diff 33318.Nov 16 2023, 1:39 AM

Rebase

Harbormaster failed remote builds in B24194: Diff 33318!Nov 16 2023, 2:19 AM
ashoat added inline comments.Nov 16 2023, 5:49 AM
lib/reducers/keyserver-reducer.js
301 ↗(On Diff #33318)

Please add a type parameterize to the Set constructor. The new version of Flow requires it

inka updated this revision to Diff 33410.Nov 20 2023, 4:42 AM

Add type

Harbormaster failed remote builds in B24272: Diff 33410!Nov 20 2023, 5:31 AM
Harbormaster completed remote builds in B24272: Diff 33410.Nov 20 2023, 7:53 AM
Closed by commit rCOMMcf7ad414cdde: [lib] Inline reduceConnectionInfo pt.2 (authored by inka). · Explain WhyNov 22 2023, 7:24 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMcf7ad414cdde: [lib] Inline reduceConnectionInfo pt.2.

Revision Contents
Changeset List

PathSize
lib/
hooks/
2 lines
reducers/
101 lines
socket/
2 lines
types/
6 lines

Diff 33506

View Options

lib/hooks/disconnected-bar.js

Loading...
View Options

lib/reducers/connection-reducer.js

Loading...
View Options

lib/reducers/keyserver-reducer.js

Loading...
View Options

lib/socket/socket.react.js

Loading...
View Options

lib/types/socket-types.js

Loading...