Page MenuHomePhabricator

[lib] Inline reduceConnectionInfo pt.2
ClosedPublic

Authored by inka on Nov 10 2023, 3:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 5:26 AM
Unknown Object (File)
Mon, Oct 28, 12:01 AM
Unknown Object (File)
Oct 10 2024, 4:29 AM
Unknown Object (File)
Oct 5 2024, 9:19 PM
Unknown Object (File)
Sep 29 2024, 5:22 AM
Unknown Object (File)
Sep 28 2024, 3:55 AM
Unknown Object (File)
Sep 28 2024, 3:55 AM
Unknown Object (File)
Sep 28 2024, 3:55 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-5352/inline-reduceconnectioninfo
See the deleted file for how it worked before
The disconnected bar and with it the lateResponses logic will be reviewd again during ENG-4126 and ENG-4125. For now I'm refactoring them in a way that 1. doesn't break the old behaviour 2. Will be easier to refactor later on

Test Plan

Dispatched setNewSessionActionType, updateDisconnectedBarActionType, logOutActionTypes, setLateResponseActionType actions and checked that the state changes as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Improve disconneted bar logic in case we want to use showDisconnectedBar for someting in the future, like for keyserver selection screen

inka requested review of this revision.Nov 10 2023, 4:03 AM

Rebase over D9664 - remove all keyservers but Ashoat's keyserver on logout and delete account.

This revision is now accepted and ready to land.Nov 14 2023, 6:07 AM
lib/reducers/keyserver-reducer.js
301 ↗(On Diff #33318)

Please add a type parameterize to the Set constructor. The new version of Flow requires it

This revision was automatically updated to reflect the committed changes.