Paths

Table of Contentst

-
lib/
-
reducers/
-
keyserver-reducer.js
2
last-communicated-platform-details-reducer.js
-
socket/
2
socket.react.js
-
types/
2
device-types.js
-
redux-types.js
-
utils/
-
action-utils.js
-
call-server-endpoint.js

[lib] Inline reduceLastCommunicatedPlatformDetails
ClosedPublic
Actions

Authored by inka on Nov 8 2023, 6:59 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM3d94daeb5510: [lib] Inline reduceLastCommunicatedPlatformDetails

Summary

issue: https://linear.app/comm/issue/ENG-5353/inline-reducelastcommunicatedplatformdetails
updateLastCommunicatedPlatformDetailsActionType is dispatched from socket and callServerEndpoint. In both of these we are in the context of one keyserver, so this action is keyserver specific

Test Plan

called updateLastCommunicatedPlatformDetailsActionType, checked that it sets the lastCommunicatedPlatformDetails correctly, chcecked that logInActionTypes sets it correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Nov 8 2023, 6:59 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 8 2023, 6:59 AM

inka published this revision for review.Nov 8 2023, 8:13 AM

Harbormaster completed remote builds in B23910: Diff 32947.Nov 8 2023, 1:08 PM

inka added a parent revision: D9763: [lib] Inline reduceUpdatesCurrentAsOf.Nov 9 2023, 3:34 AM

inka added a child revision: D9803: [lib] Inline reduceConnectionInfo pt.1.Nov 9 2023, 7:30 AM

Rebase

Harbormaster completed remote builds in B24101: Diff 33201.Nov 14 2023, 1:50 AM

michal added inline comments.Nov 14 2023, 5:12 AM

lib/reducers/keyserver-reducer.js
158 ↗	(On Diff #33201)	Do these types match? Isn't one `PlatformDetails` and the other `PlatformDetailsPayload`?
lib/reducers/last-communicated-platform-details-reducer.js
20 ↗	(On Diff #33201)	Is `registerActionTypes.success` handled somewhere?
lib/types/device-types.js
44–47 ↗	(On Diff #33201)	This would be clearer imo (but it doesn't really matter)

Address review, rebase

inka added a subscriber: varun.Nov 16 2023, 1:35 AM

inka added inline comments.

lib/reducers/keyserver-reducer.js
174–185 ↗	(On Diff #33315)	In ENG-4440 we agreed to leave the register action as is, since it will be replaced and merged with login as part of ENG-4351 @varun is that still true? If so, is there a task that talks about the login / register actions more specifically?

Harbormaster completed remote builds in B24192: Diff 33315.Nov 16 2023, 1:51 AM

michal accepted this revision.Nov 16 2023, 5:04 AM

This revision is now accepted and ready to land.Nov 16 2023, 5:04 AM

Closed by commit rCOMM3d94daeb5510: [lib] Inline reduceLastCommunicatedPlatformDetails (authored by inka). · Explain WhyNov 22 2023, 7:24 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM3d94daeb5510: [lib] Inline reduceLastCommunicatedPlatformDetails.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

35 lines

last-communicated-platform-details-reducer.js

socket/

socket.react.js

5 lines

types/

device-types.js

5 lines

redux-types.js

4 lines

utils/

action-utils.js

2 lines

call-server-endpoint.js

3 lines

Diff 33502

View Options

lib/reducers/keyserver-reducer.js

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Lines	const light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60,		subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80,		subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008',		subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100,		messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60,		modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100,		secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100,		inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60,		inviteLinkButtonBackground: designSystemColors.shadesWhite60,
		emojiKeyboardKnob: designSystemColors.shadesWhite90,
		emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
		emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
		ashoatUnsubmitted Not Done Inline Actions Do we really need one-offs here? Why can't we find an existing color family that works with our designs? We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
		ashoatUnsubmitted Not Done Inline Actions Meant to tag @ted ashoat: Meant to tag @ted
});		});
export type Colors = $Exact<typeof light>;		export type Colors = $Exact<typeof light>;

const dark: Colors = Object.freeze({		const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9',		blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60,		blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100,		codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80,		disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines	const dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f',		typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80,		typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white',		typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60,		messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80,		modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100,		secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80,		inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80,		inviteLinkButtonBackground: designSystemColors.shadesBlack80,
		emojiKeyboardKnob: designSystemColors.shadesWhite100,
		emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
		emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
});		});
const colors = { light, dark };		const colors = { light, dark };

const colorsSelector: (state: AppState) => Colors = createSelector(		const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme,		(state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => {		(theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light';		const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme];		return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines

View Options

lib/reducers/last-communicated-platform-details-reducer.js

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Lines	const light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60,		subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80,		subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008',		subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100,		messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60,		modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100,		secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100,		inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60,		inviteLinkButtonBackground: designSystemColors.shadesWhite60,
		emojiKeyboardKnob: designSystemColors.shadesWhite90,
		emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
		emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
		ashoatUnsubmitted Not Done Inline Actions Do we really need one-offs here? Why can't we find an existing color family that works with our designs? We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
		ashoatUnsubmitted Not Done Inline Actions Meant to tag @ted ashoat: Meant to tag @ted
});		});
export type Colors = $Exact<typeof light>;		export type Colors = $Exact<typeof light>;

const dark: Colors = Object.freeze({		const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9',		blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60,		blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100,		codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80,		disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines	const dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f',		typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80,		typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white',		typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60,		messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80,		modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100,		secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80,		inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80,		inviteLinkButtonBackground: designSystemColors.shadesBlack80,
		emojiKeyboardKnob: designSystemColors.shadesWhite100,
		emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
		emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
});		});
const colors = { light, dark };		const colors = { light, dark };

const colorsSelector: (state: AppState) => Colors = createSelector(		const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme,		(state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => {		(theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light';		const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme];		return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines

View Options

lib/socket/socket.react.js

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Lines	const light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60,		subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80,		subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008',		subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100,		messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60,		modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100,		secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100,		inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60,		inviteLinkButtonBackground: designSystemColors.shadesWhite60,
		emojiKeyboardKnob: designSystemColors.shadesWhite90,
		emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
		emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
		ashoatUnsubmitted Not Done Inline Actions Do we really need one-offs here? Why can't we find an existing color family that works with our designs? We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
		ashoatUnsubmitted Not Done Inline Actions Meant to tag @ted ashoat: Meant to tag @ted
});		});
export type Colors = $Exact<typeof light>;		export type Colors = $Exact<typeof light>;

const dark: Colors = Object.freeze({		const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9',		blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60,		blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100,		codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80,		disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines	const dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f',		typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80,		typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white',		typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60,		messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80,		modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100,		secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80,		inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80,		inviteLinkButtonBackground: designSystemColors.shadesBlack80,
		emojiKeyboardKnob: designSystemColors.shadesWhite100,
		emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
		emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
});		});
const colors = { light, dark };		const colors = { light, dark };

const colorsSelector: (state: AppState) => Colors = createSelector(		const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme,		(state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => {		(theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light';		const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme];		return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines

View Options

lib/types/device-types.js

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Lines	const light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60,		subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80,		subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008',		subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100,		messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60,		modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100,		secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100,		inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60,		inviteLinkButtonBackground: designSystemColors.shadesWhite60,
		emojiKeyboardKnob: designSystemColors.shadesWhite90,
		emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
		emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
		ashoatUnsubmitted Not Done Inline Actions Do we really need one-offs here? Why can't we find an existing color family that works with our designs? We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
		ashoatUnsubmitted Not Done Inline Actions Meant to tag @ted ashoat: Meant to tag @ted
});		});
export type Colors = $Exact<typeof light>;		export type Colors = $Exact<typeof light>;

const dark: Colors = Object.freeze({		const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9',		blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60,		blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100,		codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80,		disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines	const dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f',		typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80,		typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white',		typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60,		messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80,		modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100,		secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80,		inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80,		inviteLinkButtonBackground: designSystemColors.shadesBlack80,
		emojiKeyboardKnob: designSystemColors.shadesWhite100,
		emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
		emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
});		});
const colors = { light, dark };		const colors = { light, dark };

const colorsSelector: (state: AppState) => Colors = createSelector(		const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme,		(state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => {		(theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light';		const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme];		return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines

View Options

lib/types/redux-types.js

View Options

lib/utils/action-utils.js

View Options

lib/utils/call-server-endpoint.js

[lib] Inline reduceLastCommunicatedPlatformDetailsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33502

lib/reducers/keyserver-reducer.js

lib/reducers/last-communicated-platform-details-reducer.js

lib/socket/socket.react.js

lib/types/device-types.js

lib/types/redux-types.js

lib/utils/action-utils.js

lib/utils/call-server-endpoint.js

[lib] Inline reduceLastCommunicatedPlatformDetails
ClosedPublic
Actions

Revision Contents
Changeset List