This diff introduces the StatusIndicator component. We will use this component in several places, so I figured it would be good to factor this logic into its own component.
for context here are the designs:
Depends on D9887
Paths
| Differential D9888 Authored by ginsu on Nov 14 2023, 2:24 PM.
Details
Summary This diff introduces the StatusIndicator component. We will use this component in several places, so I figured it would be good to factor this logic into its own component. for context here are the designs: Depends on D9887 Test Plan
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2023, 2:24 PM2023-11-14 14:24:16 (UTC-8) ginsu edited the summary of this revision. (Show Details)Nov 14 2023, 2:26 PM2023-11-14 14:26:06 (UTC-8) Harbormaster completed remote builds in B24125: Diff 33227.Nov 14 2023, 2:56 PM2023-11-14 14:56:54 (UTC-8) ginsu added a child revision: D9891: [web] introduce keyserver selection list item.Nov 14 2023, 8:14 PM2023-11-14 20:14:04 (UTC-8) Comment Actions I kind of feel like the status indicator and the keyserver name look really far apart with a lot of blank space in between, but that's just my opinion regarding the design. This revision is now accepted and ready to land.Nov 15 2023, 7:00 AM2023-11-15 07:00:03 (UTC-8) Comment Actions
Going to land this diff for now since this concern is outside the scope of this diff/this interface is only visible to staff members/devs. However, I know we have implementing the web redesign in our roadmap, and I think that could help with the "blank space" feel. This revision was landed with ongoing or failed builds.Nov 15 2023, 10:48 AM2023-11-15 10:48:13 (UTC-8) Closed by commit rCOMMf4bed298e4f8: [web] introduce status indicator component (authored by ginsu). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B24162: Diff 33276.Nov 15 2023, 11:00 AM2023-11-15 11:00:53 (UTC-8) ginsu removed a child revision: D9891: [web] introduce keyserver selection list item.Nov 15 2023, 1:25 PM2023-11-15 13:25:46 (UTC-8)
Revision Contents
Diff 33227 web/components/status-indicator.css
web/components/status-indicator.react.js
web/theme.css
|