Page MenuHomePhabricator
Differential D9756

[native] add onPress function to keyserver selection list item
ClosedPublic
Actions

Authored by ginsu on Nov 7 2023, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 11:43 PM
Unknown Object (File)
Oct 15 2024, 7:49 AM
Unknown Object (File)
Sep 28 2024, 2:50 AM
Unknown Object (File)
Sep 28 2024, 2:50 AM
Unknown Object (File)
Sep 28 2024, 2:50 AM
Unknown Object (File)
Sep 28 2024, 2:50 AM
Unknown Object (File)
Sep 28 2024, 2:49 AM
Unknown Object (File)
Sep 12 2024, 3:19 AM
View All 49 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
inka
rohan
michal
Commits
rCOMM8073ea0aa3cd: [native] add onPress function to keyserver selection list item
Summary

This diff makes the keyserver selection list item into a TouchableOpacity and when the onPress function is triggered, navigates to the keyserver selection bottom sheet

Linear task: https://linear.app/comm/issue/ENG-5471/introduce-navigatetokeyserverselectionbottomsheet-hook

Linear task: https://linear.app/comm/issue/ENG-5471/introduce-navigatetokeyserverselectionbottomsheet-hook

Depends on D9754

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 7 2023, 12:24 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 7 2023, 12:24 PM
ginsu edited the summary of this revision. (Show Details)Nov 7 2023, 12:33 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, rohan, michal.
ginsu added a parent revision: D9754: [native] introduce keyserver selection bottom sheet ui.
ginsu attached a referenced file: F864270: Screen Recording 2023-11-07 at 3.33.17 PM.mov. (Show Details)
ginsu published this revision for review.Nov 7 2023, 11:21 PM
Harbormaster completed remote builds in B23894: Diff 32928.Nov 8 2023, 9:45 AM
ginsu added a child revision: D9794: [native] update remove keyserver text based on connection status.Nov 9 2023, 12:23 AM
inka accepted this revision.Nov 9 2023, 2:44 AM
This revision is now accepted and ready to land.Nov 9 2023, 2:44 AM
ginsu updated this revision to Diff 33230.Nov 14 2023, 2:46 PM

rebase before landing

Harbormaster completed remote builds in B24127: Diff 33230.Nov 14 2023, 3:26 PM
Closed by commit rCOMM8073ea0aa3cd: [native] add onPress function to keyserver selection list item (authored by ginsu). · Explain WhyNov 14 2023, 5:18 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM8073ea0aa3cd: [native] add onPress function to keyserver selection list item.

Revision Contents
Changeset List

PathSize
native/
profile/
24 lines

Diff 33230

View Options

native/profile/keyserver-selection-list-item.react.js

Loading...