Paths

Table of Contentst

[native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 15 2023, 8:19 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM672396bd8503: [native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo`

Summary

Similar to D9894, but for native.

Went through and made changes throughout native to support MinimallyEncodedThreadInfo where changes required were limited to updating signature.

Next diffs will involve changes that need to be made to message-specs, sendPushNotif, useResolvedThreadInfo, etc. Will start with useResolvedThreadInfo since that was limiting factor that prevented a lot of refactoring.

Depends on D9894

Test Plan

Trusting flow

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 15 2023, 8:19 AM

atul published this revision for review.Nov 15 2023, 8:21 AM

Harbormaster completed remote builds in B24159: Diff 33273.Nov 15 2023, 9:00 AM

atul added a child revision: D9896: [lib] Introduce `MinimallyEncodedResolvedThreadInfo` and start refactoring.Nov 15 2023, 10:06 AM

ashoat accepted this revision.Nov 15 2023, 12:30 PM

This revision is now accepted and ready to land.Nov 15 2023, 12:30 PM

rebase and land

This revision was landed with ongoing or failed builds.Nov 16 2023, 11:06 AM

Closed by commit rCOMM672396bd8503: [native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM672396bd8503: [native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo`.

Harbormaster failed remote builds in B24220: Diff 33354!Nov 16 2023, 11:39 AM

Revision Contents
Changeset List

Path

Size

native/

avatars/

edit-thread-avatar.react.js

7 lines

thread-avatar.react.js

11 lines

chat/

chat-router.js

7 lines

chat-thread-list.react.js

5 lines

fullscreen-thread-media-gallery.react.js

3 lines

inline-engagement.react.js

5 lines

inner-robotext-message.react.js

3 lines

inner-text-message.react.js

3 lines

message-list-types.js

5 lines

message-list.react.js

3 lines

relationship-prompt.react.js

3 lines

settings/

add-users-modal.react.js

3 lines

color-selector-modal.react.js

3 lines

emoji-thread-avatar-creation.react.js

10 lines

thread-settings-color.react.js

3 lines

thread-settings-description.react.js

3 lines

thread-settings-edit-relationship.react.js

3 lines

thread-settings-home-notifs.react.js

3 lines

thread-settings-leave-thread.react.js

3 lines

thread-settings-parent.react.js

3 lines

thread-settings-promote-sidebar.react.js

3 lines

thread-settings-push-notifs.react.js

3 lines

thread-settings-visibility.react.js

3 lines

thread-settings.react.js

8 lines

components/

community-actions-button.react.js

3 lines

thread-ancestors-label.react.js

3 lines

thread-ancestors.react.js

3 lines

thread-list.react.js

10 lines

invite-links/

manage-public-link-screen.react.js

3 lines

view-invite-links-screen.react.js

3 lines

markdown/

rules.react.js

10 lines

media/

media-gallery-keyboard.react.js

3 lines

navigation/

nav-selectors.js

3 lines

subchannels-button.react.js

3 lines

roles/

change-roles-screen.react.js

8 lines

create-roles-screen.react.js

3 lines

role-panel-entry.react.js

3 lines

role-utils.react.js

3 lines

user-profile/

user-profile-menu-button.react.js

3 lines

user-profile-relationship-button.react.js

3 lines

Diff 33273

View Options

native/avatars/edit-thread-avatar.react.js

View Options

native/avatars/thread-avatar.react.js

View Options

native/chat/chat-router.js

View Options

native/chat/chat-thread-list.react.js

View Options

native/chat/fullscreen-thread-media-gallery.react.js

View Options

native/chat/inline-engagement.react.js

View Options

native/chat/inner-robotext-message.react.js

View Options

native/chat/inner-text-message.react.js

View Options

native/chat/message-list-types.js

View Options

native/chat/message-list.react.js

View Options

native/chat/relationship-prompt.react.js

View Options

native/chat/settings/add-users-modal.react.js

View Options

native/chat/settings/color-selector-modal.react.js

View Options

native/chat/settings/emoji-thread-avatar-creation.react.js

View Options

native/chat/settings/thread-settings-color.react.js

View Options

native/chat/settings/thread-settings-description.react.js

View Options

native/chat/settings/thread-settings-edit-relationship.react.js

View Options

native/chat/settings/thread-settings-home-notifs.react.js

View Options

native/chat/settings/thread-settings-leave-thread.react.js

View Options

native/chat/settings/thread-settings-parent.react.js

View Options

native/chat/settings/thread-settings-promote-sidebar.react.js

View Options

native/chat/settings/thread-settings-push-notifs.react.js

View Options

native/chat/settings/thread-settings-visibility.react.js

View Options

native/chat/settings/thread-settings.react.js

View Options

native/components/community-actions-button.react.js

View Options

native/components/thread-ancestors-label.react.js

View Options

native/components/thread-ancestors.react.js

View Options

native/components/thread-list.react.js

View Options

native/invite-links/manage-public-link-screen.react.js

View Options

native/invite-links/view-invite-links-screen.react.js

View Options

native/markdown/rules.react.js

View Options

native/media/media-gallery-keyboard.react.js

View Options

native/navigation/nav-selectors.js

View Options

native/navigation/subchannels-button.react.js

View Options

native/roles/change-roles-screen.react.js

View Options

native/roles/create-roles-screen.react.js

View Options

native/roles/role-panel-entry.react.js

View Options

native/roles/role-utils.react.js

View Options

native/user-profile/user-profile-menu-button.react.js

View Options

native/user-profile/user-profile-relationship-button.react.js

[native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33273

native/avatars/edit-thread-avatar.react.js

native/avatars/thread-avatar.react.js

native/chat/chat-router.js

native/chat/chat-thread-list.react.js

native/chat/fullscreen-thread-media-gallery.react.js

native/chat/inline-engagement.react.js

native/chat/inner-robotext-message.react.js

native/chat/inner-text-message.react.js

native/chat/message-list-types.js

native/chat/message-list.react.js

native/chat/relationship-prompt.react.js

native/chat/settings/add-users-modal.react.js

native/chat/settings/color-selector-modal.react.js

native/chat/settings/emoji-thread-avatar-creation.react.js

native/chat/settings/thread-settings-color.react.js

native/chat/settings/thread-settings-description.react.js

native/chat/settings/thread-settings-edit-relationship.react.js

native/chat/settings/thread-settings-home-notifs.react.js

native/chat/settings/thread-settings-leave-thread.react.js

native/chat/settings/thread-settings-parent.react.js

native/chat/settings/thread-settings-promote-sidebar.react.js

native/chat/settings/thread-settings-push-notifs.react.js

native/chat/settings/thread-settings-visibility.react.js

native/chat/settings/thread-settings.react.js

native/components/community-actions-button.react.js

native/components/thread-ancestors-label.react.js

native/components/thread-ancestors.react.js

native/components/thread-list.react.js

native/invite-links/manage-public-link-screen.react.js

native/invite-links/view-invite-links-screen.react.js

native/markdown/rules.react.js

native/media/media-gallery-keyboard.react.js

native/navigation/nav-selectors.js

native/navigation/subchannels-button.react.js

native/roles/change-roles-screen.react.js

native/roles/create-roles-screen.react.js

native/roles/role-panel-entry.react.js

native/roles/role-utils.react.js

native/user-profile/user-profile-menu-button.react.js

native/user-profile/user-profile-relationship-button.react.js

[native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Revision Contents
Changeset List