Paths

Table of Contentst

Differential D9742

[docker-compose] Update deprecated localstack config
ClosedPublic
Actions

Authored by bartek on Nov 7 2023, 4:34 AM.

Tags

None

Referenced Files

	F3388420: D9742.diff
	Fri, Nov 29, 2:13 PM

	Unknown Object (File)
	Tue, Nov 26, 6:25 AM

	Unknown Object (File)
	Sun, Nov 3, 10:54 AM

	Unknown Object (File)
	Oct 26 2024, 5:14 PM

	Unknown Object (File)
	Oct 14 2024, 12:09 PM

	Unknown Object (File)
	Oct 11 2024, 12:18 PM

	Unknown Object (File)
	Oct 11 2024, 12:18 PM

	Unknown Object (File)
	Oct 11 2024, 12:18 PM

View All 59 Files

Subscribers

Details

Reviewers

kamil
michal
atul

Commits

rCOMMc1ad38cc18a6: [docker-compose] Update deprecated localstack config

Summary

Details in ENG-5677.
Some of the config environment variables for Localstack are deprecated.
I've updated them according to the docs.

Depends on D9740

Test Plan

Run localstack locally and use it (e.g. integration tests)
Stop and restart localstack container, check if the data is still there (DDB and S3 items)
Run this on CI

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Nov 7 2023, 4:34 AM

bartek held this revision as a draft.

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 7 2023, 4:34 AM

Harbormaster completed remote builds in B23840: Diff 32857.Nov 7 2023, 5:20 AM

bartek published this revision for review.Nov 12 2023, 10:52 PM

bartek edited the test plan for this revision. (Show Details)

Requesting changes because I think HLOCALSTACK_HOST should be LOCALSTACK_HOST. Feel free to re-request if I'm missing something

services/docker-compose.yml
95 ↗	(On Diff #32857)	Should this be `LOCALSTACK_HOST` instead of `HLOCALSTACK_HOST`? Here's what I'm seeing from the docs you linked: Maybe the `H` prefix has some meaning that I'm missing?

This revision now requires changes to proceed.Nov 13 2023, 9:25 AM

Actually, just make sure it's fixed before landing. Don't think it's worth requesting changes

This revision is now accepted and ready to land.Nov 13 2023, 9:25 AM

Fix typo

Harbormaster completed remote builds in B24140: Diff 33251.Nov 14 2023, 11:03 PM

Closed by commit rCOMMc1ad38cc18a6: [docker-compose] Update deprecated localstack config (authored by bartek). · Explain WhyNov 16 2023, 12:47 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc1ad38cc18a6: [docker-compose] Update deprecated localstack config.

Revision Contents
Changeset List

Path

Size

services/

docker-compose.tests.yml

3 lines

docker-compose.yml

6 lines

Diff 33312

services/docker-compose.tests.yml

Loading...

services/docker-compose.yml

Loading...