Page MenuHomePhabricator
Differential D9915

[lib] Refactor baseReducer
ClosedPublic
Actions

Authored by inka on Nov 16 2023, 8:13 AM.
Tags
None
Referenced Files
F5575696: D9915.diff
Sat, Apr 12, 6:30 PM
Unknown Object (File)
Mon, Apr 7, 2:57 PM
Unknown Object (File)
Mon, Mar 17, 11:09 PM
Unknown Object (File)
Feb 21 2025, 11:08 AM
Unknown Object (File)
Feb 21 2025, 11:08 AM
Unknown Object (File)
Feb 21 2025, 11:08 AM
Unknown Object (File)
Feb 21 2025, 11:08 AM
Unknown Object (File)
Feb 21 2025, 10:59 AM
View All 91 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM61f33774b1c0: [lib] Refactor baseReducer
Summary

issue: https://linear.app/comm/issue/ENG-5348/refactor-basereducer
We want to check this condition for every keyserver. See D1066 for context on what this code does

Test Plan

Tested that iff not connected, the inner ifs are run

Diff Detail

Repository
rCOMM Comm
Branch
inka/reducers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Nov 16 2023, 8:13 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 16 2023, 8:13 AM
inka added a parent revision: D9882: [lib] Calculate currentAsOf for every keyserver in mergeNewMessages.Nov 16 2023, 8:14 AM
Harbormaster completed remote builds in B24208: Diff 33341.Nov 16 2023, 8:39 AM
inka requested review of this revision.Nov 16 2023, 8:39 AM
ashoat added inline comments.Nov 16 2023, 9:54 AM
lib/reducers/master-reducer.js
78–81 ↗(On Diff #33341)

Invert this condition and use continue to reduce indentation

inka updated this revision to Diff 33379.Nov 17 2023, 4:54 AM

Rebase, reduce indentation

Harbormaster completed remote builds in B24241: Diff 33379.Nov 17 2023, 5:13 AM
michal accepted this revision.Nov 17 2023, 8:09 AM
This revision is now accepted and ready to land.Nov 17 2023, 8:09 AM
Closed by commit rCOMM61f33774b1c0: [lib] Refactor baseReducer (authored by inka). · Explain WhyNov 22 2023, 7:25 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM61f33774b1c0: [lib] Refactor baseReducer.
ashoat added inline comments.Nov 22 2023, 9:25 AM
lib/reducers/master-reducer.js
102 ↗(On Diff #33511)

For future reference, the new Flow requires an annotation here

ashoat added inline comments.Nov 22 2023, 9:32 AM
lib/reducers/master-reducer.js
102 ↗(On Diff #33511)

Actually, hmmm... I guess this isn't always required, as I'm not seeing any errors after rebasing. Sorry for the distraction!

Revision Contents
Changeset List

PathSize
lib/
reducers/
59 lines

Diff 33379

View Options

lib/reducers/master-reducer.js

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
} }
div.main-header > h1 { div.main-header > h1 {
color: var(--fg); color: var(--fg);
padding-left: 92px; padding-left: 92px;
font-family: var(--font-logo); font-family: var(--font-logo);
line-height: var(--line-height-text); line-height: var(--line-height-text);
font-weight: var(--semi-bold); font-weight: var(--semi-bold);
font-size: var(--logo-font-22); font-size: var(--logo-font-22);
cursor: pointer;
} }
div.main-content-container { div.main-content-container {
position: relative; position: relative;
grid-area: app; grid-area: app;
} }
div.main-content { div.main-content {
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines