[identity] Move X3DH RPCs to auth proto
ClosedPublic
Actions

Authored by bartek on Nov 23 2023, 1:53 AM.

Details

Reviewers

varun

Commits

rCOMM628a824759c5: [identity] Move X3DH RPCs to auth proto

Summary

Copied the GetOutboundKeysForUser and GetInboundKeysForUser RPCs from the client proto to the auth proto.
Kept references to the original request and response messages because they're incompatible with existing ones in the auth proto.

This one is going to be further refactored as a part of ENG-5659.
Currently, left client side unchanged until that task is done.

Depends on D9931

Test Plan

Copy-paste so ensured Identity is building. The RPC and clients will be tested when refactored to use user ID instead of username/wallet address.

Diff Detail

Repository

rCOMM Comm

Branch

barthap/identity-move-rpc

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 23 2023, 1:53 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 23 2023, 1:53 AM

Harbormaster completed remote builds in B24354: Diff 33534.Nov 23 2023, 2:12 AM

Move the inbound keys RPC too

bartek retitled this revision from [identity] Move GetOutboundKeysForUser to auth proto to [identity] Move X3DH RPCs to auth proto.Nov 27 2023, 12:10 AM

bartek edited the summary of this revision. (Show Details)

bartek published this revision for review.Nov 27 2023, 12:15 AM

bartek added inline comments.

services/identity/src/grpc_services/authenticated.rs
21 ↗	(On Diff #33628)	I had to do that because despite types being identical, they're in different modules (`crate::client_service::client_proto` vs `crate::grpc_services::authenticated::client`) so rust treats them as different types and our custom trait impls couldn't work. Also, I think they were compiled twice because of this. I'll create a Linear task for cleaning up module structure in Identity (e.g. `client_service.rs` is overgrown)