Page MenuHomePhabricator
Differential D9821

Send badgeOnly notifications in the same order as they were encrypted
ClosedPublic
Actions

Authored by marcin on Nov 10 2023, 7:19 AM.
Tags
None
Referenced Files
F3389089: D9821.diff
Fri, Nov 29, 5:31 PM
Unknown Object (File)
Mon, Nov 25, 6:21 PM
Unknown Object (File)
Oct 29 2024, 10:39 AM
Unknown Object (File)
Oct 29 2024, 10:29 AM
Unknown Object (File)
Oct 29 2024, 7:45 AM
Unknown Object (File)
Oct 29 2024, 7:36 AM
Unknown Object (File)
Oct 29 2024, 5:16 AM
Unknown Object (File)
Oct 27 2024, 8:54 PM
View All Files
Subscribers
tomek
will

Details

Reviewers
michal
kamil
ashoat
Commits
rCOMM3a05031140f9: Send badgeOnly notifications in the same order as they were encrypted
Summary

This differential repeats functionality implemented in parent differential but for badgeOnly notifications.

Test Plan

The same as for parent differential but for badgeOnly notifs.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-5191-v2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 10 2023, 7:19 AM
Herald added subscribers: will, tomek. · View Herald TranscriptNov 10 2023, 7:19 AM
marcin added a parent revision: D9819: Send visual notifications in the same order as they were encrypted.Nov 10 2023, 7:20 AM
Harbormaster completed remote builds in B23997: Diff 33071.Nov 10 2023, 7:42 AM
marcin requested review of this revision.Nov 10 2023, 7:42 AM
ashoat accepted this revision.Nov 10 2023, 12:52 PM
ashoat added inline comments.
keyserver/src/push/send.js
1576 ↗(On Diff #33071)

Can you add a Flow annotation to this collection to save me some work on the Flow upgrade?

1590 ↗(On Diff #33071)

Why is the variable still named deliveryPromise?

1707 ↗(On Diff #33071)

Please separate out the .flat() call – await should appear as the first keyword in a statement, or as the first keyword on the right hand side of an assignment. Always avoid adding calls after the await on the same line like this

This revision is now accepted and ready to land.Nov 10 2023, 12:52 PM
marcin updated this revision to Diff 33117.Nov 13 2023, 4:05 AM
  1. Address JS code quality issues.
  2. Improve typing of arrays.
Harbormaster completed remote builds in B24033: Diff 33117.Nov 13 2023, 4:32 AM
ashoat added inline comments.Nov 13 2023, 4:40 AM
keyserver/src/push/send.js
1695–1710 ↗(On Diff #33117)

Seems like these maps can be combined

marcin updated this revision to Diff 33127.Nov 13 2023, 9:12 AM

Merge two map into one when preparing badgeOnly notifications for macos.

Harbormaster completed remote builds in B24042: Diff 33127.Nov 13 2023, 9:38 AM
marcin updated this revision to Diff 33547.Nov 23 2023, 2:09 AM

Rebase before landing

Harbormaster failed remote builds in B24367: Diff 33547!Nov 23 2023, 5:27 AM
Harbormaster completed remote builds in B24367: Diff 33547.Nov 23 2023, 5:40 AM
Closed by commit rCOMM3a05031140f9: Send badgeOnly notifications in the same order as they were encrypted (authored by marcin). · Explain WhyNov 23 2023, 5:50 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM3a05031140f9: Send badgeOnly notifications in the same order as they were encrypted.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
92 lines

Diff 33547

View Options

keyserver/src/push/send.js

Loading...