Paths

Table of Contentst

-
keyserver/src/database/
-
src/
-
database/
-
migration-config.js
-
setup-db.js

[keyserver] Drop the default_role column from threads
ClosedPublic
Actions

Authored by rohan on Nov 24 2023, 10:34 AM.

Details

Reviewers

atul
ginsu
tomek

Commits

rCOMM33c67f896a0d: [keyserver] Drop the default_role column from threads

Summary

We have now been able to remove every instance of threads.default_role from SQL queries in the database, so it should now be safe to drop this column.

The stack up until this point should be fine to land as an 'intermediate' step before introducing the admin special role

Depends on D9981

Addresses ENG-5834

Test Plan

The migration succeeded and the column was dropped. I also simulated some normal behavior on Comm and made sure no parts of the app would crash

Diff Detail

Repository

rCOMM Comm

Branch

special_role

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 24 2023, 10:34 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2023, 10:34 AM

Remove semicolon

rohan edited the summary of this revision. (Show Details)Nov 24 2023, 10:38 AM

Harbormaster completed remote builds in B24409: Diff 33608.Nov 24 2023, 11:18 AM

Harbormaster completed remote builds in B24410: Diff 33609.Nov 24 2023, 11:24 AM

rohan requested review of this revision.Nov 24 2023, 11:24 AM

tomek accepted this revision.Nov 27 2023, 3:19 AM

This revision is now accepted and ready to land.Nov 27 2023, 3:19 AM

Closed by commit rCOMM33c67f896a0d: [keyserver] Drop the default_role column from threads (authored by rohan). · Explain WhyNov 27 2023, 10:36 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM33c67f896a0d: [keyserver] Drop the default_role column from threads.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

migration-config.js

11 lines

setup-db.js

1 line

Diff 33609

View Options

keyserver/src/database/migration-config.js

Show All 20 Lines
import {		import {
useServerCall,		useServerCall,
useDispatchActionPromise,		useDispatchActionPromise,
} from 'lib/utils/action-utils';		} from 'lib/utils/action-utils';

import MenuItem from '../components/menu-item.react';		import MenuItem from '../components/menu-item.react';
import Menu from '../components/menu.react';		import Menu from '../components/menu.react';
import SidebarListModal from '../modals/chat/sidebar-list-modal.react';		import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
		import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
import { useModalContext } from '../modals/modal-provider.react';		import { useModalContext } from '../modals/modal-provider.react';
import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';		import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
import ThreadMembersModal from '../modals/threads/members/members-modal.react';		import ThreadMembersModal from '../modals/threads/members/members-modal.react';
import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';		import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';		import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
import { useSelector } from '../redux/redux-utils';		import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react';		import SWMansionIcon from '../SWMansionIcon.react';
import css from './thread-menu.css';		import css from './thread-menu.css';
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines	return (
text="Leave Thread"		text="Leave Thread"
icon="logout"		icon="logout"
dangerous		dangerous
onClick={onClickLeaveThread}		onClick={onClickLeaveThread}
/>		/>
);		);
}, [onClickLeaveThread, threadInfo]);		}, [onClickLeaveThread, threadInfo]);

		const onClickPromoteSidebarToThread = React.useCallback(
		() =>
		pushModal(
		<SidebarPromoteModal
		threadInfo={threadInfo}
		onClose={popModal}
		onConfirm={onPromoteSidebar}
		/>,
		),
		[pushModal, threadInfo, popModal, onPromoteSidebar],
		);

const promoteSidebar = React.useMemo(() => {		const promoteSidebar = React.useMemo(() => {
return (		return (
<MenuItem		<MenuItem
key="promote"		key="promote"
text="Promote Thread"		text="Promote Thread"
icon="message-square-lines"		icon="message-square-lines"
onClick={onPromoteSidebar}		onClick={onClickPromoteSidebarToThread}
/>		/>
);		);
}, [onPromoteSidebar]);		}, [onClickPromoteSidebarToThread]);

const menuItems = React.useMemo(() => {		const menuItems = React.useMemo(() => {
const notificationsItem = (		const notificationsItem = (
<MenuItem key="notifications" text="Notifications" icon="bell" />		<MenuItem key="notifications" text="Notifications" icon="bell" />
);		);
const separator = <hr key="separator" className={css.separator} />;		const separator = <hr key="separator" className={css.separator} />;

// TODO: Enable menu items when the modals are implemented		// TODO: Enable menu items when the modals are implemented
Show All 33 Lines