Page MenuHomePhabricator

[keyserver] Update usage of threads.default_role in role-deleters.js
ClosedPublic

Authored by rohan on Nov 24 2023, 9:49 AM.
Tags
None
Referenced Files
F3231591: D9975.id33753.diff
Tue, Nov 12, 11:47 AM
Unknown Object (File)
Sat, Nov 9, 2:41 AM
Unknown Object (File)
Sat, Nov 9, 2:40 AM
Unknown Object (File)
Sat, Nov 9, 2:37 AM
Unknown Object (File)
Sat, Nov 9, 1:29 AM
Unknown Object (File)
Fri, Nov 8, 5:34 PM
Unknown Object (File)
Thu, Nov 7, 3:51 PM
Unknown Object (File)
Sat, Oct 26, 12:48 PM
Subscribers

Details

Summary

We need to get rid of usages of threads.default_role throughout the codebase so we can eventually drop the column.

This diff handles the usage in role-deleters.js

Existing code: Gets the default_role ID so we prevent it from being deleted (keyserver validation)

Depends on D9974

Addresses part of ENG-5833

Test Plan
  1. After updating the query, console.log the default role ID that is retrieved and make sure it corresponds to the correct role
  2. Make sure that even if the client could delete Members, the keyserver still blocks it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable