[native] Add some memoization to `ImagePasteModal`
ClosedPublic
Actions

Authored by atul on Nov 27 2023, 11:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 10:43 AM

	Unknown Object (File)
	Sat, Dec 21, 1:54 AM

	Unknown Object (File)
	Nov 16 2024, 8:06 PM

	Unknown Object (File)
	Nov 16 2024, 8:06 PM

	Unknown Object (File)
	Nov 16 2024, 8:06 PM

	Unknown Object (File)
	Nov 16 2024, 8:06 PM

	Unknown Object (File)
	Nov 16 2024, 8:05 PM

	Unknown Object (File)
	Oct 15 2024, 12:39 AM

View All 60 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMa7185f3028d3: [native] Add some memoization to `ImagePasteModal`

Summary

Noticed a few obvious issues when addressing D10059, figured I'd put up a super quick diff to address.

Test Plan

Should be noop refactor

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 27 2023, 11:56 AM

atul published this revision for review.Nov 27 2023, 12:07 PM

Thanks for fixing this up

native/chat/image-paste-modal.react.js
54 ↗	(On Diff #33762)	This could be extracted outside of the component

This revision is now accepted and ready to land.Nov 27 2023, 12:24 PM

Harbormaster failed remote builds in B24533: Diff 33762!Nov 27 2023, 12:34 PM

amend

Harbormaster completed remote builds in B24537: Diff 33766.Nov 27 2023, 1:33 PM

Closed by commit rCOMMa7185f3028d3: [native] Add some memoization to `ImagePasteModal` (authored by atul). · Explain WhyNov 27 2023, 1:34 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa7185f3028d3: [native] Add some memoization to `ImagePasteModal`.

Revision Contents
Changeset List

Path

Size

native/

chat/

image-paste-modal.react.js

46 lines

Diff 33766

View Options

native/chat/image-paste-modal.react.js

[native] Add some memoization to `ImagePasteModal`ClosedPublicActions