Paths

Table of Contentst

Differential D10252

[native] Update RelationshipList to call useUserSearchIndex
ClosedPublic
Actions

Authored by rohan on Dec 8 2023, 5:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 4:05 AM

	Unknown Object (File)
	Tue, Nov 5, 10:55 PM

	Unknown Object (File)
	Oct 14 2024, 3:42 AM

	Unknown Object (File)
	Oct 14 2024, 3:42 AM

	Unknown Object (File)
	Oct 14 2024, 3:42 AM

	Unknown Object (File)
	Oct 14 2024, 3:42 AM

	Unknown Object (File)
	Oct 14 2024, 3:42 AM

	Unknown Object (File)
	Oct 14 2024, 3:41 AM

View All 78 Files

Subscribers

Details

Reviewers

atul
ginsu
inka

Commits

rCOMM76e4ca6af009: [native] Update RelationshipList to call useUserSearchIndex

Summary

There are several search experiences in the app that do not use get/usePotentialMemberItems. This means we need to update them individually, so I'm separating out diffs to do exactly this to make it easy for reviewers. [[ https://linear.app/comm/issue/ENG-6019/[after-landing]-try-to-update-remaining-search-experiences-to-use | ENG-6019 ]] tracks attempting to update these search experiences to use usePotentialMemberItems. Each diff will affect one file ideally.

This diff affects RelationshipList.

This component is used when:

viewing friend list on native
adding friends from friend list on native
viewing block list on native

Addresses ENG-5434

Depends on D10251

Test Plan

Please see the video below where I (1) view friends list (2) add friends from friend list (3) view block list

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Dec 8 2023, 5:34 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 5:34 AM

rohan edited the test plan for this revision. (Show Details)Dec 8 2023, 5:37 AM

rohan added a child revision: D10253: [web] Update AddUsersList to call useUserSearchIndex.Dec 8 2023, 5:38 AM

rohan published this revision for review.Dec 8 2023, 6:15 AM

Harbormaster completed remote builds in B24889: Diff 34419.Dec 8 2023, 6:21 AM

ashoat added inline comments.Dec 11 2023, 9:38 AM

native/profile/relationship-list.react.js
127 ↗	(On Diff #34419)	Same issue as here

Memoize values(userInfos)

Harbormaster completed remote builds in B24947: Diff 34483.Dec 11 2023, 10:57 AM

inka added inline comments.Dec 12 2023, 1:08 AM

native/profile/relationship-list.react.js
128–142	Same as D10251. You can reduce computation in your hook if you filter the users first.

Filter users first. Tested to make sure they correctly got filtered if the conditions of excludeStatuses applied

native/profile/relationship-list.react.js
93–98 ↗	(On Diff #34546)	Just moved this down a little so I could declare `excludeStatuses` first

Harbormaster completed remote builds in B25005: Diff 34546.Dec 12 2023, 2:29 PM

inka accepted this revision.Dec 13 2023, 3:53 AM

This revision is now accepted and ready to land.Dec 13 2023, 3:53 AM

Closed by commit rCOMM76e4ca6af009: [native] Update RelationshipList to call useUserSearchIndex (authored by rohan). · Explain WhyDec 15 2023, 8:33 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM76e4ca6af009: [native] Update RelationshipList to call useUserSearchIndex.

Revision Contents
Changeset List

Path

Size

native/

profile/

relationship-list.react.js

6 lines

Diff 34483

native/profile/relationship-list.react.js

Loading...