[web] Update MembersModal to call useUserSearchIndex
ClosedPublic
Actions

Authored by rohan on Dec 8 2023, 5:25 AM.

Details

Reviewers

atul
ginsu
inka

Commits

rCOMM18187b0c7426: [web] Update MembersModal to call useUserSearchIndex

Summary

There are several search experiences in the app that do not use get/usePotentialMemberItems. This means we need to update them individually, so I'm separating out diffs to do exactly this to make it easy for reviewers. [[ https://linear.app/comm/issue/ENG-6019/[after-landing]-try-to-update-remaining-search-experiences-to-use | ENG-6019 ]] tracks attempting to update these search experiences to use usePotentialMemberItems. Each diff will affect one file ideally.

This diff affects MembersModal.

This component is used when viewing channel members on web.

Addresses ENG-5434

Depends on D10231

Test Plan

Please see the video below where I view the channel members on web

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Dec 8 2023, 5:25 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 5:25 AM

rohan edited the summary of this revision. (Show Details)Dec 8 2023, 5:27 AM

rohan edited the test plan for this revision. (Show Details)

rohan added a child revision: D10250: [web] Update SubchannelMembers to call useUserSearchIndex.Dec 8 2023, 5:28 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2023, 6:10 AM

Harbormaster failed remote builds in B24886: Diff 34416!

rohan requested review of this revision.Dec 8 2023, 6:15 AM

inka added inline comments.Dec 12 2023, 12:45 AM

web/modals/threads/members/members-modal.react.js
37–49 ↗	(On Diff #34416)	There is some logic in this file that made sure that even though we were using `userStoreSearchIndex`, we weren't displaying users from outside of this thread. It can probably be simplified now.

rohan added inline comments.Dec 12 2023, 6:46 AM

web/modals/threads/members/members-modal.react.js
37–49 ↗	(On Diff #34416)	Would you mind clarifying your original comment? My understanding with the original logic is: If there is no search term (like just opening the modal), we display `threadMembersNotFiltered` If there is a search term, we only display the `threadMembersNotFiltered`s that are a match in the search index We naturally prevented external users from being shown like you said by using `threadMembersNotFiltered` This is the same now, except now our search index just doesn't include external users. Still though, we'd need to either (1) show all members if no search term is provided or (2) only show `threadMembersNotFiltered`s that are a match in the search index Let me know if I'm misunderstanding though