Same comment as in previous diff - even though we were using userStoreSearchIndex we were only displaying the users from this thread. There is some logic in MembersList that takes care of this, that can probably be simplified now. Let me know if you think it should be left as is though, I can see that we could want that. Just wanted to flag that this should be considered

In D10250#298189, @inka wrote:

Same comment as in previous diff - even though we were using userStoreSearchIndex we were only displaying the users from this thread. There is some logic in MembersList that takes care of this, that can probably be simplified now. Let me know if you think it should be left as is though, I can see that we could want that. Just wanted to flag that this should be considered

Thanks for pointing it out - I responded to the comment in D10249 as well. I see what you mean about the logic in MembersList.

I think it'll still be good to keep as-is because all this diff does is reduce the size of the search index to the members in the parent thread (alongside making it possible to search by their ENS name). The code in MembersList that filters will still need to additionally include/exclude user IDs from the search index based on the search text.

Let me know if you disagree though

Hold on, looking at MembersList it seems we use searchResults to create parentMemberList but also otherMemberList - a list of members of the community that are not in the parent thread:

Doesn't your code make it so that the otherMemberList is always empty?
If you have a community that looks like this:

• "Community chat" members: user1, user2, user3
  • "Channel" members: user1, user2
    • "Subchannel" members: user1

And search for "user" in "Add members" modal in "Subchannel"
Isn't Not in parent chat: section empty even though it should contain user3?

In D10250#298764, @inka wrote:

Doesn't your code make it so that the otherMemberList is always empty?

I tried the example you were talking about but didn't see an issue where the otherMemberList was empty.

Creating the subchannels:

Searching in the subchannel "Add Members" modal:

Also reading the code, I think maybe there's a misunderstanding:

I think MembersList (in subchannel-members-list.react.js) is used during subchannel creation, where we list 1. users in parent channel and 2. users in the community root

For adding members to an already existing subchannel, it looks like we use AddMembersModal. That uses a different search usePotentialMemberItems that is a little more complicated and was updated in D10231, but there's no regressions introduced there.

So I think we're fine in terms of showing users. I did notice when testing that in your scenario, searching for users not in the parent thread wasn’t possible since now the search index only included members of the parent thread (before it was the entire userStore). I'll update this diff to construct the search index using the community thread info members instead