Paths

Table of Contentst

Differential D10256

[service] Move services lib to shared
ClosedPublic
Actions

Authored by michal on Dec 8 2023, 6:45 AM.

Tags

None

Referenced Files

	F2209359: D10256.id34428.diff
	Sun, Jul 7, 4:58 PM

	F2209237: D10256.id34837.diff
	Sun, Jul 7, 4:23 PM

	F2208895: D10256.id34851.diff
	Sun, Jul 7, 3:23 PM

	F2208802: D10256.diff
	Sun, Jul 7, 2:59 PM

	Unknown Object (File)
	Thu, Jul 4, 7:50 PM

	Unknown Object (File)
	Wed, Jul 3, 12:28 PM

	Unknown Object (File)
	Wed, Jul 3, 5:58 AM

	Unknown Object (File)
	Tue, Jul 2, 8:17 AM

View All 43 Files

Subscribers

Details

Reviewers

bartek
varun
kamil

Commits

rCOMM1eb7831cc2e2: [service] Move services lib to shared

Summary

Part of ENG-5555 -> in order to move the backup client from commtest to shared (to use it from native) we need to move the comm_services_lib to shared, because the client uses e.g. the UserIdentity struct. It would be good to have a common library for all Rust code in our codebase anyway. This diff also renames the library to comm_lib as it will stop being used only for services.

Test Plan

Find-and-replace comm_services_lib with comm_lib. Test if all services build.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Dec 8 2023, 6:45 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 6:45 AM

michal added a subscriber: will.Dec 8 2023, 6:48 AM

michal added a child revision: D10257: [services] Fix warnings.Dec 8 2023, 7:01 AM

Harbormaster completed remote builds in B24897: Diff 34428.Dec 8 2023, 7:50 AM

michal requested review of this revision.Dec 8 2023, 7:50 AM

This part was smoother than I thought

This revision is now accepted and ready to land.Dec 12 2023, 4:18 AM

Rebase

Harbormaster completed remote builds in B25217: Diff 34837.Dec 19 2023, 6:58 AM

Closed by commit rCOMM1eb7831cc2e2: [service] Move services lib to shared (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyDec 19 2023, 7:30 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM1eb7831cc2e2: [service] Move services lib to shared.

Revision Contents
Changeset List

Path

Size

services/

backup/

2 lines

1 line

src/

database/

2 lines

4 lines

2 lines

6 lines

http/

handlers/

2 lines

4 lines

2 lines

blob/

2 lines

1 line

src/

database/

2 lines

8 lines

4 lines

http/

handlers/

2 lines

4 lines

2 lines

2 lines

4 lines

comm-services-lib/

src/

auth/

backup/

blob/

crypto/

http/

commtest/

2 lines

1 line

src/

backup/

create_new_backup.rs

2 lines

2 lines

tests/

backup_integration_test.rs

2 lines

backup_performance_test.rs

2 lines

docker-compose.tests.yml

4 lines

feature-flags/

6 lines

1 line

src/

2 lines

2 lines

reports/

2 lines

1 line

src/

2 lines

database/

4 lines

4 lines

http/

6 lines

2 lines

2 lines

scripts/

list_services.sh

1 line

terraform/

remote/

task_blob_cleanup.tf

2 lines

test-commons.env

2 lines

	shared/	comm-lib/
	services/	comm-services-lib/

4 lines

src/

auth/

backup/

blob/

crypto/

2 lines

http/

2 lines

Diff 34851

services/backup/Cargo.lock

Loading...

services/backup/Cargo.toml

Loading...

services/backup/Dockerfile

Loading...

services/backup/src/database/backup_item.rs

Loading...

services/backup/src/database/log_item.rs

Loading...

services/backup/src/database/mod.rs

Loading...

services/backup/src/error.rs

Loading...

services/backup/src/http/handlers/backup.rs

Loading...

services/backup/src/http/mod.rs

Loading...

services/backup/src/main.rs

Loading...

services/blob/Cargo.lock

Loading...

services/blob/Cargo.toml

Loading...

services/blob/Dockerfile

Loading...

services/blob/src/database/client.rs

Loading...

services/blob/src/database/errors.rs

Loading...

services/blob/src/database/types.rs

Loading...

services/blob/src/http/handlers/blob.rs

Loading...

services/blob/src/http/mod.rs

Loading...

services/blob/src/http/utils.rs

Loading...

services/blob/src/main.rs

Loading...

services/blob/src/service.rs

Loading...

services/comm-services-lib/.gitignore

Loading...

services/comm-services-lib/Cargo.lock

Loading...

services/comm-services-lib/Cargo.toml

Loading...

services/comm-services-lib/src/auth/mod.rs

Loading...

services/comm-services-lib/src/auth/service.rs

Loading...

services/comm-services-lib/src/auth/types.rs

Loading...

services/comm-services-lib/src/backup/mod.rs

Loading...

services/comm-services-lib/src/blob/client.rs

Loading...

services/comm-services-lib/src/blob/mod.rs

Loading...

services/comm-services-lib/src/blob/types.rs

Loading...

services/comm-services-lib/src/constants.rs

Loading...

services/comm-services-lib/src/crypto/aes256.rs

Loading...

services/comm-services-lib/src/crypto/mod.rs

Loading...

services/comm-services-lib/src/database.rs

Loading...

services/comm-services-lib/src/http.rs

Loading...

services/comm-services-lib/src/http/auth.rs

Loading...

services/comm-services-lib/src/http/multipart.rs

Loading...

services/comm-services-lib/src/lib.rs

Loading...

services/comm-services-lib/src/tools.rs

Loading...

services/commtest/Cargo.lock

Loading...

services/commtest/Cargo.toml

Loading...

services/commtest/Dockerfile

Loading...

services/commtest/src/backup/create_new_backup.rs

Loading...

services/commtest/src/backup/pull_backup.rs

Loading...

services/commtest/tests/backup_integration_test.rs

Loading...

services/commtest/tests/backup_performance_test.rs

Loading...

services/docker-compose.tests.yml

Loading...

services/feature-flags/Cargo.lock

Loading...

services/feature-flags/Cargo.toml

Loading...

services/feature-flags/Dockerfile

Loading...

services/feature-flags/src/database.rs

Loading...

services/feature-flags/src/service.rs

Loading...

services/reports/Cargo.lock

Loading...

services/reports/Cargo.toml

Loading...

services/reports/Dockerfile

Loading...

services/reports/src/config.rs

Loading...

services/reports/src/database/client.rs

Loading...

services/reports/src/database/item.rs

Loading...

services/reports/src/http/mod.rs

Loading...

services/reports/src/main.rs

Loading...

services/reports/src/service.rs

Loading...

services/scripts/list_services.sh

Loading...

services/terraform/remote/task_blob_cleanup.tf

Loading...

services/test-commons.env

Loading...

shared/comm-lib/.gitignore

Loading...

shared/comm-lib/Cargo.lock

Loading...

shared/comm-lib/Cargo.toml

Loading...

shared/comm-lib/src/auth/mod.rs

Loading...

shared/comm-lib/src/auth/service.rs

Loading...

shared/comm-lib/src/auth/types.rs

Loading...

shared/comm-lib/src/backup/mod.rs

Loading...

shared/comm-lib/src/blob/client.rs

Loading...

shared/comm-lib/src/blob/mod.rs

Loading...

shared/comm-lib/src/blob/types.rs

Loading...

shared/comm-lib/src/constants.rs

Loading...

shared/comm-lib/src/crypto/aes256.rs

Loading...

shared/comm-lib/src/crypto/mod.rs

Loading...

shared/comm-lib/src/database.rs

Loading...

shared/comm-lib/src/http.rs

Loading...

shared/comm-lib/src/http/auth.rs

Loading...

shared/comm-lib/src/http/multipart.rs

Loading...

shared/comm-lib/src/lib.rs

Loading...

shared/comm-lib/src/tools.rs

Loading...