[services] Fix warnings
ClosedPublic
Actions

Authored by michal on Dec 8 2023, 7:01 AM.

Details

Reviewers

bartek
varun
kamil

Commits

rCOMM4d5b4f6c049a: [services] Fix warnings

Summary

Fixes two small warnings:

unused import
deprecation of from_utc -> replaced with from_naive_utc_and_offset

The second one is a bit tricker because the deprecation notice was introduced in a patch version, and our services used two different versions of the library. The newer version had the deprecation notice. But we can't just update all the callsites because the older version doesn't have the replacement function. Because of that I also pinned this library in all of our dependencies to the newer patch version.

Depends on D10256

Test Plan

Check if services compile.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Dec 8 2023, 7:01 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 7:01 AM

michal added a child revision: D10258: [comm-lib] Hide aws behind a feature flag.Dec 8 2023, 7:05 AM

Harbormaster completed remote builds in B24898: Diff 34430.Dec 8 2023, 8:22 AM

michal requested review of this revision.Dec 8 2023, 8:22 AM

Finally 🎉

The second one is a bit tricker because the deprecation notice was introduced in a patch version, and our services used two different versions of the library. The newer version had the deprecation notice. But we can't just update all the callsites because the older version doesn't have the replacement function. Because of that I also pinned this library in all of our dependencies to the newer patch version.

I remember I coudn't figure it out when I tried fixing it once

Looks like now I'll have to rebase D10301 to get the fix there too

This revision is now accepted and ready to land.Dec 12 2023, 4:21 AM

Closed by commit rCOMM4d5b4f6c049a: [services] Fix warnings (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyDec 19 2023, 7:30 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM4d5b4f6c049a: [services] Fix warnings.

bartek mentioned this in D10762: [identity] Remove deprecated conversion traits.Jan 22 2024, 3:44 AM