Page MenuHomePhabricator
Differential D10288

[lib] Add setConnectionIssueActionType
ClosedPublic
Actions

Authored by inka on Dec 11 2023, 2:06 AM.
Tags
None
Referenced Files
F3356054: D10288.id34469.diff
Sat, Nov 23, 4:38 PM
F3355844: D10288.id34737.diff
Sat, Nov 23, 3:50 PM
F3355141: D10288.diff
Sat, Nov 23, 2:00 PM
Unknown Object (File)
Mon, Nov 18, 8:10 AM
Unknown Object (File)
Thu, Nov 7, 11:28 PM
Unknown Object (File)
Oct 16 2024, 9:41 PM
Unknown Object (File)
Oct 16 2024, 9:41 PM
Unknown Object (File)
Oct 16 2024, 9:41 PM
View All 74 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
ginsu
kamil
tomek
Commits
rCOMMbe372d9837a9: [lib] Add setConnectionIssueActionType
Summary

issue: https://linear.app/comm/issue/ENG-5990/add-setconnectionissue-action
This is an action used to set connectionIssue field.

Test Plan

Dispatched the action, checked that the connectionIssue is set in the keyserver store.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Dec 11 2023, 2:06 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 11 2023, 2:06 AM
inka added a parent revision: D10287: [lib] Add connectionIssue field.Dec 11 2023, 2:07 AM
Harbormaster completed remote builds in B24935: Diff 34469.Dec 11 2023, 2:37 AM
inka requested review of this revision.Dec 11 2023, 2:37 AM
ashoat added inline comments.Dec 13 2023, 5:28 PM
lib/types/redux-types.js
1243 ↗(On Diff #34469)

Make the object read-only please!

inka added a child revision: D10331: [lib] Call logout when connectionIssue is set.Dec 14 2023, 4:25 AM
ginsu accepted this revision.Dec 14 2023, 9:32 AM

please make sure to address @ashoat's comment before landing

This revision is now accepted and ready to land.Dec 14 2023, 9:32 AM
inka updated this revision to Diff 34737.Dec 15 2023, 9:18 AM

Make read only

Harbormaster completed remote builds in B25130: Diff 34737.Dec 15 2023, 9:52 AM
inka added a reviewer: tomek.Dec 19 2023, 2:23 AM
inka updated this revision to Diff 34898.Dec 21 2023, 2:45 AM

Make possible to set connectionIssue to null / undefined

Harbormaster completed remote builds in B25265: Diff 34898.Dec 21 2023, 3:40 AM
Closed by commit rCOMMbe372d9837a9: [lib] Add setConnectionIssueActionType (authored by inka). · Explain WhyDec 22 2023, 1:13 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMbe372d9837a9: [lib] Add setConnectionIssueActionType.

Revision Contents
Changeset List

PathSize
lib/
reducers/
16 lines
types/
5 lines
3 lines

Diff 34962

View Options

lib/reducers/keyserver-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/socket-types.js

Loading...