Page MenuHomePhabricator
Differential D10292

[lib][web][native] Simplify logout call
ClosedPublic
Actions

Authored by inka on Dec 11 2023, 9:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 5:31 AM
Unknown Object (File)
Tue, Jul 2, 6:01 PM
Unknown Object (File)
Tue, Jul 2, 6:01 PM
Unknown Object (File)
Tue, Jul 2, 6:01 PM
Unknown Object (File)
Tue, Jul 2, 6:01 PM
Unknown Object (File)
Tue, Jul 2, 6:01 PM
Unknown Object (File)
Tue, Jul 2, 2:03 PM
Unknown Object (File)
Mon, Jul 1, 6:00 AM
View All 36 Files
Subscribers
ashoat

Details

Reviewers
tomek
michal
varun
Commits
rCOMM97e2dec68c52: [lib][web][native] Simplify logout call
Summary

Now that actions are wrapped in hooks we can select data in them. This simplfies the calling code and reduces repetition.

Test Plan

Checked that it is possible to log out and back in with no errors showing up. Checked that invalidSessionDowngrade works correctly (by loggin out and back in before logoutActionTypes.success was dispatched)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Dec 11 2023, 9:57 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 11 2023, 9:57 AM
Harbormaster completed remote builds in B24945: Diff 34480.Dec 11 2023, 10:18 AM
inka requested review of this revision.Dec 11 2023, 10:18 AM
varun resigned from this revision.Dec 11 2023, 10:48 PM

thanks for adding me as a reviewer! lgtm, but going to let someone else with more react expertise take a look

tomek accepted this revision.Dec 12 2023, 12:22 AM
tomek added inline comments.
lib/actions/user-actions.js
102 ↗(On Diff #34480)

How about renaming it to e.g. const callKeyserverLogOut = useKeyserverCall(logOut);

This revision is now accepted and ready to land.Dec 12 2023, 12:22 AM
inka added a child revision: D10331: [lib] Call logout when connectionIssue is set.Dec 14 2023, 4:25 AM
inka updated this revision to Diff 34738.Dec 15 2023, 9:20 AM

Rename

Harbormaster completed remote builds in B25131: Diff 34738.Dec 15 2023, 9:48 AM
Closed by commit rCOMM97e2dec68c52: [lib][web][native] Simplify logout call (authored by inka). · Explain WhyDec 22 2023, 1:13 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM97e2dec68c52: [lib][web][native] Simplify logout call.

Revision Contents
Changeset List

PathSize
lib/
actions/
14 lines
socket/
6 lines
native/
components/
12 lines
profile/
9 lines
6 lines
web/
settings/
10 lines

Diff 34961

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/socket/socket.react.js

Loading...
View Options

native/components/version-supported.react.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...
View Options

native/socket.react.js

Loading...
View Options

web/settings/account-settings.react.js

Loading...